Dgrid does not play well with Dijit bordercontainer about dgrid HOT 9 CLOSED

I found a couple of revisions worth making to your test case, but your test case also exposed a couple of tiny bugs in dgrid at the same time, so it was worth it for both ends. :)

Here's a gist with suggested revisions to your test case: https://gist.github.com/4ea187b11473a0240a65
(the earlier revision of that gist is the original contents from this issue; the later revision has some fixes, so you can compare them).

Fixes in dgrid that this uncovered:

11fca4b
2dadeb9

Hopefully this resolves the issue; let us know if it doesn't. Thanks!

from dgrid.

@kfranqueiro Thanks for fixing this and pointing out those improvements. I realized that wrapping the Dgrid in a content pane was an option that makes the Dgrid behave better (even without those other improvements). It seems like one should be able to use the Dgrid directly in a dijit layout (like Border Container) without wrapping it. Is this something that is not supported?

from dgrid.

Yeah, currently dgrid doesn't behave as it would need to in order to work as a direct child of a Dijit layout widget. It's something we are likely to investigate further, as this isn't the first time the question has been raised.

from dgrid.

@kfranqueiro Thanks for the update on this. I would lobby for making this work like every other gadget in dojo - they can be dropped directly into any layout. Just my 2 cents.

from dgrid.

My worthless 2c: yes please. I just spent 1 hour figuring out that a dgrid doesn't work when added to a contentpane. The issue I came across is that widgetId is not set in the DOM. So, getChildren() simply ignores those (it uses the registry).

IF adding widgetId is the only change, then maybe it is worth doing. However, I suspect it might not be...

In the meantime, I will happily wrap the dgrid. But!

from dgrid.

Actually as of dgrid 0.3.5, DijitRegistry has what it takes to make dgrid work as a direct child of dijit layout widgets.

from dgrid.

Hi,

I tried it, but the dgrid doesn't seem to set widgetId in the Dom, and
getChildren() fails to find it. Things display weird in BorderContainer
after that...

Merc.

Merc.
On 29/03/2013 9:10 AM, "Kenneth G. Franqueiro" [email protected]
wrote:

Actually as of dgrid 0.3.5, DijitRegistry has what it takes to make dgrid
work as a direct child of dijit layout widgets.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/119#issuecomment-15624322
.

from dgrid.

https://github.com/SitePen/dgrid/blob/v0.3.6/extensions/DijitRegistry.js#L19 does exactly what you are referring to. Are you sure you're mixing in dgrid/extensions/DijitRegistry?

from dgrid.

Hi,

Ah, I am now, and it actually works. No, I wasn't mixing in DijitRegistry
(which does a lot if fiddly things -- thanks for writing this).
Yes I will stop asking idiotic questions at some point.

(Thanks for your patience)

Merc.

On 29 March 2013 09:57, Kenneth G. Franqueiro [email protected]:

https://github.com/SitePen/dgrid/blob/v0.3.6/extensions/DijitRegistry.js#L19does exactly what you are referring to. Are you sure you're mixing in
dgrid/extensions/DijitRegistry?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/119#issuecomment-15625480
.

from dgrid.