Breaking out msg/time/level about logrus HOT 8 CLOSED

What do you think should happen in the case where you create a field with the name msg, time or level then?

from logrus.

Those should just be fields like any other fields. There shouldn't be magic keys that you have to avoid. If I want to pass "time" as a field meaning "the time the request was originally made," that shouldn't collide with the time the log message was created.

Rob

On May 19, 2014, at 6:14 PM, Simon Eskildsen [email protected] wrote:

What do you think should happen in the case where you create a field with the name msg, time or level then?

—
Reply to this email directly or view it on GitHub.

from logrus.

What should the default field name for time be then? I'm ok with making it up with the formatter, but I'm not getting you completely here.

from logrus.

I mean that Entry should have Msg, Time, and Level members of the struct rather than just mappings in Data:
type Entry struct {
Logger *Logger
Msg string
Time time.Time
Level Level
Data Fields
}

I know there are some backward compatibly questions, but v0.2 suggests your API isn't stable yet, so some breaking changes should be expected (good to do it all at once though). I don't think this will impact people unless they've written their own formatters, though.

This would get rid of lines like:

if key != "time" && key != "level" && key != "msg" {

Rob

On May 19, 2014, at 10:27 PM, Simon Eskildsen [email protected] wrote:

What should the default field name for time be then? I'm ok with making it up with the formatter, but I'm not getting you completely here.

—
Reply to this email directly or view it on GitHub.

from logrus.

Yeah, I'm on board with that and it makes sense. It doesn't solve one of the issues you talked about though, namely what to do in the situation when you log a field with the name msg, time or level.

from logrus.

If you log a field called msg, time, or level, nothing special should happen. It should print out in the list of data fields just like if you log a field called error or stuff. That way everything sent to .WithField() is treated the same.

from logrus.

I really don't get that part of the solution. Can you come up with an example?

from logrus.

#48

from logrus.