Giter Club home page Giter Club logo

Comments (11)

isidrorg avatar isidrorg commented on July 3, 2024

+1

from terraform.

lunelson avatar lunelson commented on July 3, 2024

Alternatively, pleeease is also worth looking at

from terraform.

kennethormandy avatar kennethormandy commented on July 3, 2024

Thanks. Personally, I would on board with having Autoprefixer, and I think it fits well with Harp’s philosophy as long as it’s not configurable. We would need a post-processing step for all CSS, though, which doesn’t exist right now, but would also be nice to place to fix #30

Any chance you’d be interested in submitting a pull request for it if @sintaxi is also interested?

from terraform.

sintaxi avatar sintaxi commented on July 3, 2024

I think you guys have the right idea. The question I have is should this be the responsibility of Harp or of a Sass/Less/Stylus library? If so, is there going to be situations people do not want the auto-prefix behaviour?

from terraform.

lunelson avatar lunelson commented on July 3, 2024

I regret to say I don't have the expertise to plug this in and submit a PR myself. I can say that autoprefixer runs on a framework called PostCSS, which is by the same author. Also it's independent of Stylus/LESS/Sass, since it is a discrete second step, usually needing a CSS output file to work from, though it's also apparently been made to work with a streaming style workflow as a gulp plugin.

It does also have configuration questions: namely, which browsers (how far back) to support with the added prefixes, and also whether to process source-maps or not. So I don't know if that's perhaps contrary to the philosophy of Harp. Incidentally: do source-maps get handled with Harp? I know that LESS and libsass both can output them; not sure about Stylus. Anyway the reason I asked about integrating it in the pipeline, is that I've found that the main application which is post-processing and live-reloading needs to be aware of the autoprefixer step, or the workflow (mainly the live-reloading) is thrown off. In the case of Harp even more so I guess, due to the css source being entirely hidden—otherwise I'd say let's just have a way to hook it up with Grunt or something.

from terraform.

DTrejo avatar DTrejo commented on July 3, 2024

+1

Great work with harp, very much enjoying it so far :)

from terraform.

geelen avatar geelen commented on July 3, 2024

Popped a PR in for autoprefixer here: #57

from terraform.

subhaze avatar subhaze commented on July 3, 2024

@sintaxi

... is there going to be situations people do not want the auto-prefix behaviour?

My guess is yes, but, I would definitely love to see this behavior in harp.

So, maybe it could be triggered in the pipeline just like the mime types? If you don't want it, nothing to be done and keeping using harp as you have been, but, if you do just add the extension prefix and it's there.

myfile.jade         ->  myfile.html
myfile.xml.jade     ->  myfile.xml

---

myfile.less             ->  myfile.css
myfile.css.less         ->  myfile.css
myfile.prefix-css.less  ->  myfile.css // auto-prefixed css

from terraform.

geelen avatar geelen commented on July 3, 2024

I really don't think there's a good reason not to use autoprefixer. Given
harp's focus on 'zero configuration, smart behaviour', I would argue that
autoprefixing-all-the-things makes the most sense.

On 8 September 2014 05:41, Michael Russell [email protected] wrote:

@sintaxi https://github.com/sintaxi

... is there going to be situations people do not want the auto-prefix
behaviour?

My guess is yes, but, I would definitely love to see this behavior in harp.

So, maybe it could be triggered in the pipeline just like the mime types?
If you don't want it, nothing to be done and keeping using harp as you have
been, but, if you do just add the extension prefix and it's there.

myfile.jade -> myfile.html
myfile.xml.jade -> myfile.xml


myfile.less -> myfile.css
myfile.css.less -> myfile.css
myfile.prefix.less -> myfile.css // auto-prefixed css


Reply to this email directly or view it on GitHub
#45 (comment).

from terraform.

kennethormandy avatar kennethormandy commented on July 3, 2024

v0.9.0 of Terraform is actually already tagged and comes with @geelen’s integration of Autoprefixer, the next version of Harp will include it.

We decided the situations where people wanted to opt-out of automatic vendor prefixing would be so rare that it fit under the convention over configuration philosophy Harp uses. In the next version of Harp, if you write LESS, Sass, or Stylus, you CSS will be vendor prefixed, and if you write CSS, it won’t be.

Edit I had this tab open all evening, so I didin’t see @geelen’s comment until after I posted. But basically, that!

from terraform.

subhaze avatar subhaze commented on July 3, 2024

Awesome and agreed, didn't realize it had already been merged... Viewing the linked issue I see that now :) Was just giving some additional thoughts if it were still being debated, but, thankfully it's not!

from terraform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.