Comments (6)
I have a similar issue with DistributedOmit
The simple following type does not work
type ReplaceKey<T, V> = T extends { key: string } ? DistributedOmit<T, 'key'> & { key: V } : T
I get the following error
TS2344: Type "key" does not satisfy the constraint KeysOfUnion<T>
from type-fest.
Why?
from type-fest.
we were build a component wrapper which disallow passing some specific props directly
the Omit
in typescript works great until some one come in with a union typed props
here is the demo
import type { DistributedOmit } from 'type-fest';
type DistributedOmitLoose<
ObjectType,
KeyType extends keyof any,
> = ObjectType extends unknown ? Omit<ObjectType, KeyType> : never;
type SomeComponentPropsTypeWithControl = {
onChange: (value: any) => void;
controllable: true;
};
type SomeComponentPropsTypeWithoutControl = {
controllable: false;
};
type SomeComponentProps =
| SomeComponentPropsTypeWithoutControl
| SomeComponentPropsTypeWithControl;
// works
type Result1 = Omit<SomeComponentProps, 'value'>;
// works and exactly what i want
type Result2 =
| Omit<SomeComponentPropsTypeWithControl, 'value'>
| Omit<SomeComponentPropsTypeWithoutControl, 'value'>;
// loose constraint. works. same as Result2
type Result3 = DistributedOmitLoose<SomeComponentProps, 'value'>;
// DistributedOmit from package
// Type '"value"' does not satisfy the constraint 'keyof SomeComponentPropsTypeWithoutControl'
type Result4 = DistributedOmit<SomeComponentProps, 'value'>;
IMO, when omitting properties from a interface, there's no need to check if they were actually exist.
That's why TS's Original Omit didn't check the 2nd type argument. (Just my opinion, not checked if it's right)
from type-fest.
I do agree that it would be nice to support this use-case. One downside is that it then would not be able to auto-complete the key.
from type-fest.
@henriqueinonhe Thoughts?
from type-fest.
DistributedOmitLoose
This is fantastic, thank you. In a heavily abstracted layer of framework code, it's most often not possible to get autocompletion on Omit anyway. This is a great drop in replacement for DistributedOmit.
from type-fest.
Related Issues (20)
- Zero is not exported by ... HOT 1
- `And` and `Or` is not exported at `index.d.ts`
- ConditionalKeys does not correctly filter out `never` type HOT 3
- Paths<T> should handle recursive types
- `PickDeep` strips `null` HOT 7
- `schema` should properly set type of objects in arrays HOT 3
- `SimplifyDeep` doesn't deep simplify lists HOT 3
- `IsStringLiteral` should be `false` for branded and tagged types
- `CamelCasedPropertiesDeep` doesn't handle `Tagged` type correctly HOT 1
- `IfxxxLiteral` (eg `IfBooleanLiteral`) are missing (only the `IsxxxLiteral` is present
- `PartialDeep` doesn't work with arrays HOT 3
- Document `IntRange` `Start` param must be `>=0`
- `Exact` does not work as expected with type involving `Date` and union HOT 2
- Web-specific version of `StructuredCloneable` type HOT 10
- Add `IsNullable` and `IsOptional`
- `LiteralList<Union>` HOT 2
- Exact not function correctly with Dates since last commit HOT 8
- Type `{}` is not assignable to type `PartialDeep<T>` HOT 1
- Expose Max Recursion Depth of Paths HOT 2
- Issues with `Paths` type HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from type-fest.