Giter Club home page Giter Club logo

Comments (10)

fregante avatar fregante commented on May 23, 2024 2

What's the practical difference to #42

I think that's difference. It's just a combination of them:

Unpromise<ReturnType<typeof asyncFunction>>
ResolvedType<typeof asyncFunction>

Funny thing is that all the examples in #38 and #42 are exactly:

Unpromise<ReturnType<typeof asyncFunction>>

So perhaps ResolvedType makes more sense than a standalone Unpromise.


Also maybe it should be called AsyncReturnType instead of ResolvedType

from type-fest.

resynth1943 avatar resynth1943 commented on May 23, 2024 2

PR welcome for AsyncReturnType.

@sindresorhus Since you're accepting PRs for this, do you want me to submit one for this after PromiseValue has been merged?

from type-fest.

sindresorhus avatar sindresorhus commented on May 23, 2024 1

@resynth1943 Yes. That would be great. 🙌

from type-fest.

BendingBender avatar BendingBender commented on May 23, 2024

What's the practical difference to #42 (apart from the fact that ResolvedType is a combination of ReturnType and the proposed Unpromise)?

from type-fest.

sindresorhus avatar sindresorhus commented on May 23, 2024

@dylang ⬆️

from type-fest.

fregante avatar fregante commented on May 23, 2024

This is what I'm using currently:

type Unpromise<MaybePromise> = MaybePromise extends Promise<infer Type> ? Type : MaybePromise;
type AsyncReturnType<T extends (...args: any) => any> = Unpromise<ReturnType<T>>

You can probably merge the two and avoid Unpromise but I don't know how 😳

from type-fest.

sindresorhus avatar sindresorhus commented on May 23, 2024

I still think Unpromise makes sense as an independent building block.

PR welcome for AsyncReturnType.

from type-fest.

sindresorhus avatar sindresorhus commented on May 23, 2024

Relevant TypeScript issue: microsoft/TypeScript#28105

from type-fest.

fregante avatar fregante commented on May 23, 2024

@sindresorhus I think that's more about Unpromise and AsyncReturnType

A PR for that issue has been opened: microsoft/TypeScript#35998

from type-fest.

resynth1943 avatar resynth1943 commented on May 23, 2024

Gotcha. When you get a chance, @sindresorhus, could you check out #75?

from type-fest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.