Allow sorting NaN values about num-sort HOT 15 CLOSED

It currently throws TypeError: Expected a number.

from num-sort.

I prefer a breaking change.

from num-sort.

Correct

from num-sort.

What is the current behavior?

from num-sort.

What is the reasoning for it being considered lowest rather than highest?

from num-sort.

NaN means not a number which means nothing which means 0.

from num-sort.

Well but 0 is not the lowest possible number 😅

from num-sort.

0 is the smallest natural number and is usually a fallback for NaN so it's obvious for it to be the smallest number.

from num-sort.

What do you think should be the expected result for [1, -1, NaN].sort(numberSort.ascending)?

from num-sort.

[NaN, -1, 1]

from num-sort.

So you're treating NaN as -Infinity, not 0.

My opinion is that this is arbitrary and often not intended. How about, instead, adding an option?

const numberSort = require('num-sort');

console.log([1, NaN, -4, 3].sort(numberSort.ascending({ treatNanAs: -Infinity })));
//=> [NaN, -4, 1, 3]

from num-sort.

I agree, NaN should be last, after -Infinity.

from num-sort.

So you're treating NaN as -Infinity, not 0.

Infinity is technically a number. NaN is not, hence it should be first/last.

from num-sort.

@sindresorhus Do you prefer a breaking change (simply change the existing behavior) by arbitrarily choosing between first/last, or do you think an option such as I suggested is possible?

from num-sort.

@sindresorhus One last confirmation:

[1, -1, -Infinity, NaN].sort(numberSort.ascending)
//=> [NaN, -Infinity, -1, 1]

[1, -1, -Infinity, NaN].sort(numberSort.descending)
//=> [1, -1, -Infinity, NaN]

Is this correct? If yes I'll submit a PR

from num-sort.