Comments (6)
I like idea behind this library. Unfortunately, I am not able to use it as other thousands of developers using create-react-app
.
Reply to #28 (comment):
- I don't believe that stable CRA v2 will be release in next 6 months - I would love to be wrong here ;)
- read your explanation in sindresorhus/ama#446 but KY declared that it targets browsers so your main point is not valid for Ky
@sindresorhus Please consider to build version compatible with current version create-react-app
. I am sure that it will help KY adoption a lot. If you check download rate at https://www.npmjs.com/package/ky and compare it to number of GitHub stars then you have to see unbalance there. I believe it is because ppl like KY concept but they can't use it.
from ky.
I don't transpile my modules. If you need support for older browsers, it's up to you to transpile for what you target. sindresorhus/ama#446
FYI, create-react-app
v2 will transpile dependencies, and will hopefully be out soon.
from ky.
I agree that this issue should be considered in tools like webpack
or babel
, but I guess it's not coming anytime soon. And for the sake of simplicity of using the library, I'll still definitely go for a transpile, at least for the current standard (which is ES5 for now), as this is ridiculously easy with tools like rollup
or parcel
. That would save a lot of time of developers finding out why this is not working (because the errors are not very descriptive) - you can see clearly how much on the issue you've just linked. But... that's just my opinion, you're still the boss here 😄 Thanks for explaining your position on this!
P.S. Of course I mean only packages that are specifically aimed for browsers. Like this one 😄
from ky.
In order to get this to work I would normally just add the module (ky) to the Webpack babel-loader include like so:
{
test: /\.js$/,
include: [
path.join(__dirname, './src'),
path.join(__dirname, './node_modules/ky')
],
loader: 'babel-loader'
},
But it seems that with the new version of @babel they no longer allow you to use the root project's babel config (in .babelrc
or package.json
) to transpile another module with it's own package.json so I get an error that says Support for the experimental syntax 'objectRestSpread' isn't currently enabled
even though my root project's config is using a preset that DOES have support for this.
So for anyone else running into this, the only solution I've found is to move the config out of package.json
and into babel.config.js
.
from ky.
I don't believe that stable CRA v2 will be release in next 6 months - I would love to be wrong here ;)
LOL, create-react-app v2 was just released 🤣(see https://reactjs.org/blog/2018/10/01/create-react-app-v2.html)
from ky.
Continued in #44
from ky.
Related Issues (20)
- "fetch() request with GET/HEAD/OPTIONS method cannot have body" in Bun HOT 2
- retry is wrongly counting HOT 1
- Error: `unsupported BodyInit type` on some runtimes HOT 1
- Ky does not pass custom options down to the native fetch HOT 4
- is there a way to prevent HttpError when response is not in range HOT 2
- POST request fails in Astro.js API route HOT 5
- Header not set on node version 18.18.2 HOT 14
- [help] trying to understand why headers are not set properly HOT 1
- 1.1.1 breaks multipart form boundary HOT 6
- Passing { next: { revalidate, tags } } options to ky does not work in NextJS edge (at least with dev server) HOT 10
- Tests are hanging HOT 2
- Best way to handle Fetch errors such as Failed to fetch, NetworkError when attempting to fetch resource, etc. HOT 1
- Retries on timeout HOT 1
- TypeError: signal.throwIfAborted is not a function HOT 9
- Support for SSL client certificate in Nodejs undici HOT 1
- How to abort retry before hitting the retry limit?
- Cannot use import statement outside a module, Jest HOT 1
- Types for headers HOT 2
- How to handle HTTP Delete Method (204) with ky?
- [BUG] When Response is a string(not valid JSON), `json` method occurs error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ky.