Giter Club home page Giter Club logo

Comments (5)

sindresorhus avatar sindresorhus commented on July 18, 2024

What is the user expected to do/use then when internal-ip can't find the IP?

from internal-ip.

silverwind avatar silverwind commented on July 18, 2024

I'd expect them to handle the thrown error depending on their use case. For some use cases, it might be appropriate to use the localhost addresses, but for others, a different action might be more fitting. I think it's not our responsibility to decide that.

from internal-ip.

silverwind avatar silverwind commented on July 18, 2024

Simple example: You use internal-ip to retrieve the local ip on server1 and communicate it to server2. For server2, the value of 127.0.0.1 would be outright wrong because it refers to their loopback address instead of the one on server1.

from internal-ip.

sindresorhus avatar sindresorhus commented on July 18, 2024

Alright. I don't think it should throw though. It seems like it's an expected failure, and null would be more appropriate, I think. Our docs should mention when it could possibly return null and suggest how to handle it in different scenarios.

from internal-ip.

silverwind avatar silverwind commented on July 18, 2024

Yeah, null seems reasonably here. I'll change this once #14 has landed.

from internal-ip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.