Giter Club home page Giter Club logo

Comments (16)

kornelski avatar kornelski commented on May 18, 2024 1

Finder shows size underneath the file name, in a smaller font

screenshot 2019-01-25 at 23 13 49

from gifski.

kornelski avatar kornelski commented on May 18, 2024 1

Maybe you could animate the icon as dropping into the window? Give it some physical motion so that it doesn't feel attached to the window.

from gifski.

IssueHuntBot avatar IssueHuntBot commented on May 18, 2024

@issuehuntfest has funded $200.00 to this issue. See it on IssueHunt

from gifski.

sentialx avatar sentialx commented on May 18, 2024

Would it be okay?

from gifski.

sindresorhus avatar sindresorhus commented on May 18, 2024

Looks a bit uneven. Should probably be centered.


From the linked discussion:

to show a proxy icon (an icon that and acts like a Finder icon: can be dragged to other apps and double clicked)

It should also have a proxy icon that can be dragged.

from gifski.

sentialx avatar sentialx commented on May 18, 2024

Okay, I will see what I can do about this.

from gifski.

sindresorhus avatar sindresorhus commented on May 18, 2024

Here's a quick mockup of what I have in mind. Feedback wanted.

gifski-share-view-mockup

The thing in the middle is a file icon (proxy icon) that is draggable.

I would also like to see the system Share button being placed somewhere there too, to able to quickly share the GIF.

from gifski.

kornelski avatar kornelski commented on May 18, 2024

Maybe Finder's alias arrow would make it clearer that this is a proxy icon? alias arrow

There's also NSRevealFreestandingTemplate named image for a loupe icon that means revealing in Finder. I'm not sure if it's necessary, but it's an option if you'd like more compact UI or avoid words.

from gifski.

sentialx avatar sentialx commented on May 18, 2024

Is this what you wanted? The file size and the name are not real. Of course I will get the file data, but I was focusing on the proxy icon. See how it works

from gifski.

IssueHuntBot avatar IssueHuntBot commented on May 18, 2024

@sentialx has submitted a pull request. See it on IssueHunt

from gifski.

sindresorhus avatar sindresorhus commented on May 18, 2024

@sentialx Yes, but the icon should be a little bit larger and I think we should go with what @kornelski shows in #48 (comment), with the size below the title and in smaller font. The font should also be slightly bolder and lighter.

from gifski.

sindresorhus avatar sindresorhus commented on May 18, 2024

Maybe Finder's alias arrow would make it clearer that this is a proxy icon?

Why would it? For me then it looks like I'm dragging out an alias of the file.

I do agree we should make it clearer somehow that it can be dragged.

from gifski.

sindresorhus avatar sindresorhus commented on May 18, 2024

There's also NSRevealFreestandingTemplate named image for a loupe icon that means revealing in Finder. I'm not sure if it's necessary, but it's an option if you'd like more compact UI or avoid words.

The problem with NSRevealFreestandingTemplate is that it cannot really be used in a button, but the share icon should. It's probably best if the two buttons, "reveal" and "share", are on the same vertical line, below the icon, so would be best if they looked the same.

For reference, here's how they look (top and bottom icon):

screen shot 2019-01-29 at 21 14 06

Maybe we could find a looking glass icon on https://thenounproject.com/ that would fit with the share icon. Or do something else. I'm open to ideas.

from gifski.

sentialx avatar sentialx commented on May 18, 2024

@sindresorhus Maybe we could pulse the scale of the image view and add a tooltip that it's draggable?

from gifski.

sindresorhus avatar sindresorhus commented on May 18, 2024

Yeah, let's try with some pulsating first and see how it feels.

from gifski.

IssueHuntBot avatar IssueHuntBot commented on May 18, 2024

@sindresorhus has rewarded $180.00 to @sentialx. See it on IssueHunt

  • 💰 Total deposit: $200.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $20.00

from gifski.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.