always reports "datasource is working" about grafanajsondatasource HOT 8 CLOSED

it may be a Grafana issue (v 6.4.3)

Once a good URL is used with the datasource instance, changing to a bad URL will always show "data source is working", even if I leave and return to the datasource config.

Also strange is that even with a new datasource instance, I never see "data source is not working" for known bad URL's. It will just show "testing" briefly, and then no message box.

from grafanajsondatasource.

I couldn't reproduce the problem with other datasources (I tried InfluxDB), so it may be an issue with this plugin's implementation of testDatasource()?

I notice that json-datasource is merely returning an error response, while influxdb is throwing it:

https://github.com/simPod/grafana-json-datasource/blob/34f531c4d00ee92fdb708670deed4ca17dc43d85/src/datasource.ts#L57-L62

https://github.com/grafana/grafana/blob/fcde26e2dbd87bb864444714dff155dacc631e97/public/app/plugins/datasource/influxdb/datasource.ts#L338-L342

from grafanajsondatasource.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from grafanajsondatasource.

I believe it might be wrong. TBH I have not touched related code since forking from Grafana and never questioned it. I'll look into it when I have time or you can send PR. I guess it's not severe issue.

from grafanajsondatasource.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from grafanajsondatasource.

I suggest reviewing your project's staleness policy

from grafanajsondatasource.

It is required to return status code 200. I just tested with status codes != 200 and it reports "not working" correctly. How to reproduce?

from grafanajsondatasource.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from grafanajsondatasource.