Giter Club home page Giter Club logo

Comments (2)

mojabyte avatar mojabyte commented on June 13, 2024 1

The problem is using the refBox[variantKey] to calculate the arrowVariantVal in:

nanopop/src/index.ts

Line 196 in 4913582

refBox[variantKey] + refBoxCenterOffset : variantVal + variantSize / 2;

refBox position values are calculated from the viewport. Still, when applied to the arrow that is a descendant of an element with the transform style, it is positioned based on that element instead of the viewport (Elements with transforms act as a containing block for fixed position descendants). This is why the arrow is positioned wrong horizontally in the above example.

The wrong vertical position is because of this line:

nanopop/src/index.ts

Line 199 in 4913582

if (positionVal < refBox[positionKey]) {

that similarly uses refBox[positionKey].

Using matched position and variant keys to infer the arrow position offsets from the popper position will fix the issue. I've proposed a fix in this PR #26.

from nanopop.

simonwep avatar simonwep commented on June 13, 2024

Hey! This is awesome (your issue, not the bug haha) - thank you for this elaborate bug-report and description :D I'll comment on your PR!

from nanopop.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.