Giter Club home page Giter Club logo

Comments (5)

simogeo avatar simogeo commented on August 21, 2024

it's not a bug, it's a feature! By the way, the /userfiles/ folder should be protected by .htaccess file similar to that :

<IfModule mod_php5.c>
php_value engine off
</IfModule>
<IfModule mod_php4.c>
php_value engine off
</IfModule>
Options -Indexes*

I'm still available to discuss that point

from filemanager.

Ne0nx3r0 avatar Ne0nx3r0 commented on August 21, 2024

I'm just thinking this opens a lot of doorways to XSS attacks and such, if someone found a creative way to make a file that .htaccess wasn't stopping.

It might be a good idea to allow an ACL on file types.

What is the benefit of being able to change the file extension?

from filemanager.

simogeo avatar simogeo commented on August 21, 2024

Indeed, I'm not sure there is a benefit.
Regarding ACL and file extensions, see issue #43

from filemanager.

 avatar commented on August 21, 2024

I believe it should be a concern of the connector file; perhaps the connector should get it's own allowed/denied extensions and use it for upload/rename.

from filemanager.

simogeo avatar simogeo commented on August 21, 2024

Done, see commit a663764

from filemanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.