BrookFCLHTTPAppBroker lacks JSON support about brookframework HOT 12 CLOSED

Friend, you can close this issue. It's OK, and thank you very much! 👍

from brookframework.

The same procedure HandleUnknownEncoding is repeated in all routers with exactly the same source code. Maybe we should move out this functionality in some common helper function?
It will be something like

procedure TBrookHTTPConnectionRequest.HandleUnknownEncoding(const AContentType: string;
  AStream: TStream);
begin
   HandleUnknownEncodingHelper(Self, AContentType, AStream);
end;

What do you think?

from brookframework.

You can create it and send to the working branch, so we can test it.

ps. I'm testing all your changes in router. ;)

from brookframework.

What file should we place this new function? Create a new broker-helper unit, or somewhere in the 'core'?

from brookframework.

You can create a new unit called as BrookHTTPDefsBroker or other better name, and paste all your shared broker functions there.

from brookframework.

Ok! I think Page404 and Page500 handlers also could be moved there.

from brookframework.

Very nice!

from brookframework.

You're working on it? After we close this issue, I'll do a merge to master. 👍

from brookframework.

I'm stuck with inheritance problem. Trying to find a solution.

from brookframework.

Tell me about it. :)

from brookframework.

We need to override virtual method HandleUnknownEncoding()
But all three our brokers inherits from different childs of TRequest:
HTTPApp Broker: TFPHTTPConnectionRequest
CGI Broker: TCGIRequest
FastCGI Broker: TFCGIRequest

We can't make common child TBrookRequest and override HandleUnknownEncoding() method here, because each application needs its own parent class.

So I moved functionality to external functions, and forced to pass original object as argument. Not very nice solution, I'm not sure it is better than was before.

from brookframework.

Yeah, that's why I implemented separately. :)

Another detail, might happen a broker to need a specific change. But this is not the case, we keep as you already did, with functions.

Your code it's great, I made just a simple cleaning. Thank you very much! (now you can close this issue 👍 )

from brookframework.