Giter Club home page Giter Club logo

Comments (11)

stevehipwell avatar stevehipwell commented on July 24, 2024 4

@ankitnayan did you reach out to the Loki team at Grafana then before creating your benchmark if you didn't understand how to tune Loki correctly? Or for that matter to even understand what Loki is and what it isn't?

This is a prime example of how not to benchmark; a lack of understanding of the systems at test, comparing apples to oranges, and arbitrary tests which are unlikely to be actual real world workflows.

from logs-benchmark.

ankitnayan avatar ankitnayan commented on July 24, 2024 4

@stevehipwell we got a reply from Grafana on the above link.

Screenshot 2023-02-06 at 12 18 12 PM

from logs-benchmark.

wardbekker avatar wardbekker commented on July 24, 2024 2

+1 on @stevehipwell comment. If you are going to include Loki, please use it in the way it's intended. Happy to give tips on more representitive testing.

Shameless plug: See also Effective troubleshooting with Grafana Loki - query basics https://www.youtube.com/watch?v=UiiZ463lcVA

from logs-benchmark.

stevehipwell avatar stevehipwell commented on July 24, 2024 1

@ankitnayan if you don't understand how something works then how can you include it in a benchmark let alone make that benchmark fair?

from logs-benchmark.

danpoltawski avatar danpoltawski commented on July 24, 2024

Another +1 to @stevehipwell comment. The whole Loki architecture is built upon being fast to query and not needing to index. Really misleading to create this 'benchmark'

Would be more interesting to compare a real use case of querying

from logs-benchmark.

ankitnayan avatar ankitnayan commented on July 24, 2024

I failed to find any resources on the capacity planning of loki and the performance of different types of queries. I see a closed issue at grafana/loki#3182. It would be great if someone can publish docs on resources needed. If someone is willing to run this on a generic dataset, we would be happy to collaborate.

from logs-benchmark.

ankitnayan avatar ankitnayan commented on July 24, 2024

@stevehipwell I would appreciate some efforts in ingesting and filtering logs in Loki over a dataset rather than asking to move Loki out of comparison. I really thought about it multiple times before posting the blog. I wanted to encourage collaboration on a good dataset and bring out the best configs from all the log management tools.

We also shared that Loki did not run successfully for even low-cardinality data. Quoting the query from the blog

logs count with method GET per 10 min over the entire data (low cardinality timeseries)

Get first 100 logs with method GET (logs based on filters)

If you think the users don't use Loki for the queries mentioned in the blog. Let me know the right set of queries to benchmark it against. If you think it is supposed to perform poorly in some scenarios, share the use cases. We have already mentioned the high-cardinality usecase.

Also please do share resource usage and perf numbers and scale of your setup.

I am here to improve the stated results in the benchmark for the overall benefit of the users.

from logs-benchmark.

ankitnayan avatar ankitnayan commented on July 24, 2024

I am sensing rage rather than contribution. No worries, all PRs to the setup and discussions around perf and setup rather than texts are welcome.

from logs-benchmark.

stevehipwell avatar stevehipwell commented on July 24, 2024

@ankitnayan not rage, more incredulity. Instead of holding your hand up over this and either removing Loki until you understand how it could be compared or reaching out to Grafana you're asking me, a random person, to help you with your benchmark.

from logs-benchmark.

ankitnayan avatar ankitnayan commented on July 24, 2024

Done. I will wait for a reply before reaching out at non-public channels
https://community.grafana.com/t/how-to-tune-loki-for-better-performance-in-a-benchmark/80709

from logs-benchmark.

vaskozl avatar vaskozl commented on July 24, 2024

Does loki OOM under the benchmark?

from logs-benchmark.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.