Comments (2)
@hackerrdave thanks for opening this. We do plan on adding this to the Elasticsearch instrumentation. This would be part of a larger planned audit for inferred service compatibility and upstream instrumentations in the near future.
Depending on your use case, we think that the cluster name would be the preferred db.instance
value as there could be some cardinality concerns with using index names. Perhaps being able to configure which to use would be ideal.
In the meantime there isn't a* span tags parameter like with some other instrumentations, so no immediate workaround seems available. Of course opening a PR for the instrumentation is always an option if your schedule allows it 😄
from signalfx-python-tracing.
great thanks for the update! Agreed on the db.instance
value being the cluster name rather than the index names. I may be able to try to work this in, just wanted to confirm that this is something that we wanted to do, and wasn't already being worked on. It does seem to be a bit of a larger refactor than the other recent changes to pymysql since that integration was already refactored in a way to have access to span tags, but I'll see what I can do!
from signalfx-python-tracing.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from signalfx-python-tracing.