Giter Club home page Giter Club logo

Comments (6)

xldenis avatar xldenis commented on May 24, 2024 1

Can this be closed?

from signal-desktop.

aprescott avatar aprescott commented on May 24, 2024

Are dependencies currently pulled in from their minified form, or are they added in and then later minified? Seems like it would be safest to audit the original version then have a minimal, trustworthy minifier so you control the minification step.

from signal-desktop.

TheBlueMatt avatar TheBlueMatt commented on May 24, 2024

Yes, that is reasonable...currently I think they're mostly in originally-minified form, but there may be an exception or two.

from signal-desktop.

liliakai avatar liliakai commented on May 24, 2024

Let's just not minify things, and let's unminify the things we already have. We're not really benefitting much from minification. See discussion on #78 (comment).

from signal-desktop.

mspl13 avatar mspl13 commented on May 24, 2024

If #78 is closed because the reasons mentioned there, couldn't this one also be closed since this thread basically ends with a reference to it?

from signal-desktop.

TheBlueMatt avatar TheBlueMatt commented on May 24, 2024

Feel like this should probably be re-opened. The full list of things which are each in the security domain for users relying on the security of Signal-Desktop has gotten more than a little bit absurd, at least if my understanding of the yarn.lock file is correct.

from signal-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.