Comments (6)
Can this be closed?
from signal-desktop.
Are dependencies currently pulled in from their minified form, or are they added in and then later minified? Seems like it would be safest to audit the original version then have a minimal, trustworthy minifier so you control the minification step.
from signal-desktop.
Yes, that is reasonable...currently I think they're mostly in originally-minified form, but there may be an exception or two.
from signal-desktop.
Let's just not minify things, and let's unminify the things we already have. We're not really benefitting much from minification. See discussion on #78 (comment).
from signal-desktop.
If #78 is closed because the reasons mentioned there, couldn't this one also be closed since this thread basically ends with a reference to it?
from signal-desktop.
Feel like this should probably be re-opened. The full list of things which are each in the security domain for users relying on the security of Signal-Desktop has gotten more than a little bit absurd, at least if my understanding of the yarn.lock file is correct.
from signal-desktop.
Related Issues (20)
- Security Issue: No verification required after copying %AppData%\Signal to another device HOT 2
- Frequent database errors that crashes Signal. Restart possible, but errors increasingly more frequent HOT 7
- Send story preview image shouldn't be interactive HOT 1
- Clicking "Create/upload sticker pack" immedaitely crashes Signal HOT 4
- Stories Sent From Desktop do not Sync with Mobile HOT 3
- Message delay reaches 37 minutes HOT 4
- Increase sticker size limit for animated stickers HOT 1
- Segmentation fault signal-desktop 6.45.0-1 HOT 2
- Deleted Media might not be actually deleted HOT 1
- macOS: Render process is gone HOT 11
- Receive group message requests from blocked contact on desktop version HOT 9
- Error - GPU process isn't usable. HOT 2
- Padding on profile icon is incorrect HOT 1
- Group Members. Cruft? "Unknown," "No groups in common" HOT 1
- Mac OS exit full-screen window option not available HOT 1
- Desktop app changes chat color to default (blue) on voice message speed change HOT 1
- Can't see contact info from message request HOT 2
- Signal beta crashes on startup HOT 7
- "This person isn't using Signal" HOT 1
- update readme to mention 'yarn' as npm doesn't work presently HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from signal-desktop.