Giter Club home page Giter Club logo

Comments (6)

jamiebuilds-signal avatar jamiebuilds-signal commented on June 2, 2024

Really sorry that you're experiencing this. I've been trying different things to try and reproduce it but so far I've been unable to. Are you still able to reproduce this issue in 7.7.0?

Screenshot of VoiceOver captions: "Du bist jetzt auf: Textfeld. Durch Tippen auf einer Tastatur gibst du Text in dieses Feld ein."

From your logs I can see that we are resolving to the correct locale:

# you have not changed the app locale in settings
INFO  2024-04-27T10:25:31.579Z got fast localeOverride setting null

# loaded correct preferred system languages
INFO  2024-04-25T13:10:56.489Z app.ready: preferred system locales: de-DE, en-DE

# matches correct locale
INFO  2024-04-25T13:10:56.490Z locale: Matched locale: de

# we log this after loading the locale so we can tell it loaded properly
INFO  2024-04-25T13:10:56.505Z locale: Text info direction for de: ltr

from signal-desktop.

MarcoZehe avatar MarcoZehe commented on June 2, 2024

Yes, this problem still exists in version 7.7.0. I have a suspiciion that this might be an Electron problem. I am experiencing a similar bug in Microsoft's Skype for Desktop. Its UI is also in German, so it gets my unchanged system locale correctly as well, but VoiceOver speaks everything in English there, too. So my suspicion is that Electron, Chromium or a combination of both always communicates the app language to VoiceOver to be English. Meaning the basic engine, before any of the app stuff is even loaded, and for some reason prevents the overriding of the language via the web content. I don't know enough about chromium or Electron to debug this, but as I am seeing this in two separate Electron apps, the evidence is substantial.

from signal-desktop.

jamiebuilds-signal avatar jamiebuilds-signal commented on June 2, 2024

With Electron Fiddle we could potentially create a smaller reproducible example for the Electron team to fix the issue. I created a basic gist to update the document locale based on the system locale loaded by electron.

  1. Download Electron Fiddle: https://www.electronjs.org/fiddle
  2. Load this gist: https://gist.github.com/89dba0f6f94c185b5625f22c3bb95461
  3. Click "Run" and it'll launch a small app and you can test it out if it has the same problem

Bildschirmfoto 2024-05-09 um 3 25 57 PM

from signal-desktop.

MarcoZehe avatar MarcoZehe commented on June 2, 2024

This fiddle works as expected in both 27.1.3 and the default version of Electron 30 that is downloaded initially with Electron Fiddle. I also made sure to add a simple plain paragraph of German text below the button to make sure. Both are read in German as expected.

from signal-desktop.

jamiebuilds-signal avatar jamiebuilds-signal commented on June 2, 2024

Played around with the possibility that it could be a build issue or a race condition and I'm coming up short. Is there anything you can think of that's unique about your device settings, app installation, etc?

If you download the Signal Beta, you can open up DevTools with Command+Option+I and inspect the <html> element to ensure it has lang="de" set properly

Bildschirmfoto 2024-05-15 um 12 54 11 PM

from signal-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.