Protobuf error in electron application about libsignal-protocol-javascript HOT 6 CLOSED

Thanks a lot for the help. Using the info you provided, I managed to get the script loading without the error messages, while maintaining node integration.

        <script>
            window.nodeRequire = require;
            delete window.require;
        </script>
        <script src="./node_modules/libsignal-protocol/dist/libsignal-protocol.js"></script>
        <script>
            window.require = window.nodeRequire;
            delete window.nodeRequire;
        </script>

I can confirm that it works end to end in electron now.
Again thanks a lot for the tip, it helped immensely.

Electron actually highlights such an issue in their FAQ http://electron.atom.io/docs/faq/.

from libsignal-protocol-javascript.

The droids you are looking for are likely being attached to module.exports instead of window. Someday I hope we'll support a node-compatible build. Until then, you'll have to disable node integration in the renderer if you want to use this libaray as-is.

from libsignal-protocol-javascript.

I have created the minimal project required to reproduce the issue.

git clone https://github.com/McPo/electron-quick-start.git
cd electron-quick-start
git checkout libsignal
npm install
npm start

It should take less than a minute to get it up and going.

You should notice the error messages in the console.
However if you open the index.html file in chrome, there should be no error messages.

from libsignal-protocol-javascript.

dcodeIO appears to return ByteBuffer in Electron and a Protobuf in Chrome. Hence the undefined Protobuf in Electron. (This may be more relevant for the Electron repo, however I imagine other users would wish to use libsignal within an Electron app).

Electron

Chrome

from libsignal-protocol-javascript.

Thanks @McPo, you just saved me from a night of head-banging ^^'!

from libsignal-protocol-javascript.

Thanks @McPo !

from libsignal-protocol-javascript.