Giter Club home page Giter Club logo

Comments (4)

SherifEldeeb avatar SherifEldeeb commented on May 16, 2024

Actually there are few discrepancies between the schema and the rules every now and then ... author is defined as str, but here it's a list:
https://github.com/Neo23x0/sigma/blob/master/rules/windows/sysmon/sysmon_susp_certutil_command.yml

Sorry for bringing this over and over, I already do check for those issues in the code that parses the rules, but consistency between the schema and the sample rules will make a better case for wider sigma adoption.

from sigma.

thomaspatzke avatar thomaspatzke commented on May 16, 2024

Factually, sigmac currently implements A, but the specification defines str. Fixing it to str and adding the or syntax to conditions would make the parsing harder and the condition harder to read in my opinion. Same for author: list-only would add unneeded single-item lists to many rules while str-only will make rules with multiple authors unstructured.

On the whole, I think we should keep this flexibility in Sigma and allow str and list. Unfortunately, the used Schema language (Kwalify) doesn't support such alternatives, while Rx does. A switch to Rx could give us this flexibility. I discuss this with Florian.

from sigma.

thomaspatzke avatar thomaspatzke commented on May 16, 2024

Ok, following plan: we switch to a Rx schema definition with alternatives.

from sigma.

thomaspatzke avatar thomaspatzke commented on May 16, 2024

Schema has updated to Rx schema with possibilities for strings and lists of strings mentioned above.

from sigma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.