Giter Club home page Giter Club logo

Comments (6)

domnantas avatar domnantas commented on June 10, 2024 1

Figured that out a bit later 😅 There are no instructions on README to copy the issue template to your project. Ideally, it would automatically default to https://github.com/sidx1024/report-nyc-coverage-github-action/blob/main/comment-template.md (or the .svelte one) if template does not exist in your project

from report-nyc-coverage-github-action.

TaighHawkins avatar TaighHawkins commented on June 10, 2024 1

Yeah, while I can understand that providing your own template is useful, there's no need to provide a template if you just want the default template (given that it exists within the action at hand).
I'm happy to have this issue closed if either:

  • The readme is updated to indicate that you need to copy the template/write your own template in your own repo
  • The action is updated to use the template in the action root if none has been provided

But as it stands, there's no indication that you should use your own template, and it is entirely possible to use the one in the action.

from report-nyc-coverage-github-action.

yassinebebba avatar yassinebebba commented on June 10, 2024 1

if you don't use your own template the action will fail, and even if you provide one you endup with an error that says missing fields

Error: Error: Invalid or missing tokens: base_ref,base_short_commit_sha,base_commit_link,base_total_statements_coverage_percent,total_statements_coverage_percent_diff,base_total_branches_coverage_percent,total_branches_coverage_percent_diff,base_total_functions_coverage_percent,total_functions_coverage_percent_diff,base_total_lines_coverage_percent,total_lines_coverage_percent_diff

from report-nyc-coverage-github-action.

domnantas avatar domnantas commented on June 10, 2024

Getting the same error

from report-nyc-coverage-github-action.

yassinebebba avatar yassinebebba commented on June 10, 2024

this is the template
https://github.com/sidx1024/report-nyc-coverage-github-action/blob/main/comment-template.md

from report-nyc-coverage-github-action.

sidx1024 avatar sidx1024 commented on June 10, 2024

It was a bug. Please use one of the newer releases which has this issue fixed.

from report-nyc-coverage-github-action.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.