Comments (8)
@sidsharma2002 , Can you please elaborate this.
from practiceapp.
Repository classes and room database with the use of hilt will complete the MVVM architecture
from practiceapp.
If I introduce the concept of repository with Dagger Hilt, this needs to be modify the whole app, and make changes in most of the files.
from practiceapp.
not in every class. setup hilt create an empty repository inject it into ViewModelA.kt. that's it. Change only ViewModelA, do you want me to assign you this issue?
from practiceapp.
from practiceapp.
yes it is
from practiceapp.
Thanks for assigning this issue to me. I have created a new branch for this implementation named "issue_1_setup_mvvm", is it ok or should I make changes in the master branch?
from practiceapp.
No you have done correctly. It is how a pr is expected to be made just make sure you create one pr pr commit. Meaning your pr should only contain one commit
from practiceapp.
Related Issues (18)
- ADD PERSISTENT BOTTOM SHEET IN THE MAIN ACTIVITY HOT 3
- Error while Launching activity HOT 3
- Apply Debouncing in Api Calls
- Add comments in MyWorker.kt HOT 1
- Apply DiffUtil in HomeRvAdapter Or Migrate to ListAdapter HOT 1
- Use NetworkBoundResource for caching
- Fix project and get it to a useable state : Create FakeRepository for backend apis
- Add Benchmark Tests
- Add BaseLine profiles
- Add UnitTests
- Start Migrating some screens to Compose
- Modularise the app
- REFACTOR : Cleanify the Code
- Add best practices section to README.md HOT 2
- Add resources section in README.md
- Add same properties but using Threads instead of coroutines HOT 2
- Addition of resources from MindOrks in readme HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from practiceapp.