Schedules aren't pulled from Redis when changed about sidekiq-scheduler HOT 8 CLOSED

Hi'll take a look at this and comment back with my findings.

Thanks for the report.

from sidekiq-scheduler.

Indeed there was an error and the changes made in to the schedule are lost can you check this PR #36 to see if it would work for you?

To issue a schedule change you have to:

  Sidekiq.set_schedule('some_name', { 'every' => ['1m'], 'class' => 'HardWorker' })

from sidekiq-scheduler.

Seems to work for me.

Only thing i'm wondering is if there should be some kind of tests for this functionality?

from sidekiq-scheduler.

Yes this was just to test if that would work for you.

I'll add some tests and some kind of helper for testing that a schedule change has been issued.

from sidekiq-scheduler.

Works like a charm 👍

from sidekiq-scheduler.

When will this be merged into master?

from sidekiq-scheduler.

Can you check the last version of this PR?
I added a test for it and test helper in case anyone wants to the test if their code is issuing schedule changes correctly.

If everything is ok i'll merge this into master and release a new version.

from sidekiq-scheduler.

👍 works for me, but i`m waiting for merge

from sidekiq-scheduler.