[Kernel] remove dead code about siconos HOT 6 CLOSED

My point of view :

• utils/contract/check.hpp : we can remove it but it seems that it has already been removed
• factories : I am not fond of factories, but it can be useful in the future if we design a GUI over the the standard DS.
• SiconosSet/Cmp. We can put into an old directory or in siconos-junk
• swapInMemory in DS are used in most of the time--stepping at every time-step. The goal is to replace this functionality by another one ?

from siconos.

• Vincent Acary [email protected] [2016-04-23 14:36:58 -0700]:

My point of view :

• utils/contract/check.hpp : we can remove it but it seems that it has already been removed

Right. Someone else took care of this.

• factories : I am not fond of factories, but it can be useful in the future if we design a GUI over the the standard DS.

Ok. I'll try to document that somehow.

• SiconosSet/Cmp. We can put into an old directory or in siconos-junk

I can do that (moving to siconos-junk)

• swapInMemory in DS are used in most of the time--stepping at every time-step. The goal is to replace this functionality by another one ?

Right. I missed the call to swapInMemory because it is done in a nice way in OneStepIntegrator::saveInMemory, with a std::bind and thus no '()'. My regexp didn't see it.
Mystery solved :)

I'm hijacking this bug report, but shouldn't we remove OneStepIntegrator::saveInMemory and in Simulation::saveInMemory iterate over the DSs of the indexSet0? We already do it this way for the Interaction (Simulation::pushInteractionsInMemory). This way we remove one use of OSIDynamicalSystems !

from siconos.

In fact, I have already removed the iteration over the DynamicalSet and replaced it by iteration on the OneStepIntegrator::_dynamicalSystemGraph. The solution is a little bit less elegant because I don't know how to use the std::bind method on the internal set::vector or std::map of the graph.

Any idea ?

from siconos.

from siconos.

It seems that there is nothing more to implement. Should we close ?

from siconos.

I removed SiconosSet/Cmp with e966d11

Closing since everything has been done from my POV

from siconos.