Giter Club home page Giter Club logo

Comments (7)

JackDandy avatar JackDandy commented on May 22, 2024

I'm going to close this because we have made changes to Subliminal in the following branch which will go live before the end of January. You are welcome to test if your issue exists on this branch and feedback, otherwise you can wait and then report back when that branch is merged (if you need to).

from sickgear.

BhaalM avatar BhaalM commented on May 22, 2024

I'll try the new branch thank you. Any advice on how to send subliminal debug log messages to the sickgear log file?

from sickgear.

JackDandy avatar JackDandy commented on May 22, 2024

Unfortunately, It's not as trivial as logs. This is exactly why we ask for steps to replicate the issue, because if you communicate those steps clearly, then we are able to load things up in a dev system and freeze/step through the code while replicating your issue in order to pinpoint an exact cause.

from sickgear.

BhaalM avatar BhaalM commented on May 22, 2024

I understand, thank you anyway (for your help and for your work on this project)

from sickgear.

BhaalM avatar BhaalM commented on May 22, 2024

I found the problem, it seems the spanish subtitles of opensubtitles lack a lot of information (no video hashes) so I changed the list_checked function:

def list_checked(self, video, languages):
results = []
if video.exists:
results = self.query(video.path or video.release, languages, moviehash=video.hashes['OpenSubtitles'], size=str(video.size))
elif video.imdbid:
results = self.query(video.path or video.release, languages, imdbid=video.imdbid)
elif isinstance(video, Episode):
results = self.query(video.path or video.release, languages, query=video.series)
elif isinstance(video, Movie):
results = self.query(video.path or video.release, languages, query=video.title)
return results

to:

def list_checked(self, video, languages):
    results = []
    if video.exists:
        results = self.query(video.path or video.release, languages, moviehash=video.hashes[\'OpenSubtitles\'], size=str(video.size))

    if not results:
        if video.imdbid:
            results = self.query(video.path or video.release, languages, imdbid=video.imdbid)
        elif isinstance(video, Episode):
            results = self.query(video.path or video.release, languages, query=video.series)
        elif isinstance(video, Movie):
            results = self.query(video.path or video.release, languages, query=video.title)
    return results

I know I'll may download out of sync subtitles, but I prefer this.

from sickgear.

JackDandy avatar JackDandy commented on May 22, 2024

This feature request is now available in the develop branch.

  • Add "Enforce media hash match" to config/Subtitles Plugin/Opensubtitles for accurate subs if enabled, but if disabled, search failures will fallback to use less reliable subtitle results

from sickgear.

JackDandy avatar JackDandy commented on May 22, 2024

Available in master here.

from sickgear.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.