make code more pythonic about impfbot HOT 7 CLOSED

@sibalzer

For settings.py:
Since everything is checked now (as of 9310053) all of the code after config generation is obsolete and only needs to be run when a config.ini is provided by the user (and not generated). We could move it to a separate function then.

Also, I'd suggest using one const NOTIFIERS used by config_generator.py, settings.py, alerts.py and wherever else it might be needed. This way, we could reduce lines of code in several places.

from impfbot.

I've written tests this time to be safe 😅 (tests for settings.py still missing). Still, i'll test everything manually before the release to be on the safe side.

from impfbot.

5/5 yay

from impfbot.

• config_generator.py

could also use some improvements

from impfbot.

Also, I'd suggest using one const NOTIFIERS used by config_generator.py, settings.py, alerts.py and wherever else it might be needed. This way, we could reduce lines of code in several places.

i've over engineered settings.py in make-code-more-pythonic for v3.0.0 making use of NOTIFIERS. alerts.py is in queue.

from impfbot.

Looks great!
That's a lot of changes though, we'll have to make sure everything works as expected.

from impfbot.

closed by #83

from impfbot.