Command I ran: <div class="snippet-clipboard-content notranslate position-relative

SQL Permissions checking seems to be broken about sw-cli-tools HOT 2 OPEN

shopwarelabs commented on June 27, 2024

SQL Permissions checking seems to be broken

from sw-cli-tools.

Comments (2)

baurmatt commented on June 27, 2024

Ah I think I now get it. You're trying to change the database collation/char set:

$docroot/recovery/install/src/Service/DatabaseService.php

        return $this->connection->exec(
            sprintf(
                '%s DATABASE `%s` CHARACTER SET `%s` COLLATE `%s`',
                $dbExists ? 'ALTER' : 'CREATE',
                $name,
                $charset,
                $collation
            )
        );

Which is fine, but could you please check if that is already correct?

root@mbaur:/var/log/mysql# mysql -e 'show create database shopware'
+----------+-------------------------------------------------------------------------------------------+
| Database | Create Database                                                                           |
+----------+-------------------------------------------------------------------------------------------+
| shopware | CREATE DATABASE `shopware` /*!40100 DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci */ |
+----------+-------------------------------------------------------------------------------------------+

from sw-cli-tools.

baurmatt commented on June 27, 2024

Also, the following SQL breaks for a use configured like 'shopware'@'10.128.3.%':

$docroot/recovery/install/src/Service/DatabaseService.php

            $sql = <<<'EOL'
SELECT PRIVILEGE_TYPE, REPLACE(GRANTEE,"'","") AS _grantee
FROM information_schema.SCHEMA_PRIVILEGES
WHERE PRIVILEGE_TYPE=:priv AND TABLE_SCHEMA=:name
HAVING _grantee = USER()
OR _grantee=CONCAT(SUBSTRING_INDEX(USER(),'@',1),'@%')
EOL;

from sw-cli-tools.

Recommend Projects