Comments (2)
volmer
commented on May 17, 2024
We can discuss this better in the Policial repo or in the policial channel, but I personally never merge on a red policial. The only reason to do it is in case of a bug in the service IMO.
Something we did on Checkout is to run RuboCop on BuildKite. It required us to cleanup all checkout files (which we did quite fast with autocorrect), and now style violations are CI failures, not just Policial.
from ruby-style-guide.
airhorns
commented on May 17, 2024
Ok reopening over there.
from ruby-style-guide.
Related Issues (20)
- Should we expose our style guide as a gem? HOT 3
- Proposition: Disable `Style/CaseEquality` HOT 5
- Missing Creative Commons attribution
- Add a Table of Contents
- Add anchors to each rule
- Add more good vs bad examples
- Include reasoning in some rules
- Policial complains about implicit string concatenation for triple-quoted strings HOT 3
- Layout/LineLength obsolete parameter `IgnoredPatterns`
- Style/HashSyntax EnforcedShorthandSyntax setting HOT 1
- Gemspec/DateAssignment cop has been removed. HOT 1
- Recommendation on Style/ArrayIntersect? HOT 2
- Autoformat issues with v2.11.1 HOT 3
- Cut a release to eliminate rubocop 1.4 warning? HOT 2
- Suggestion: enforce trailing commas in literals HOT 30
- Style guide style improvements HOT 6
- detect over find for AR associations? HOT 3
- disable Style/ClassAndModuleChildren cop for tests HOT 4
- Time (and Date) doesn't always have equivalents of DateTime methods HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby-style-guide.