VideoCodec still running after stream is close() about haishinkit.swift HOT 9 CLOSED

The specification is that during a pause, the last frame continues to be sent. This is done to prevent audio and video desynchronization on the viewer's end when video is continuously dropped.

from haishinkit.swift.

Thanks for the clarification.

In this case (with the sample), even after 1/2 min, the encoder still running. Not sure this is only the last frame :)

from haishinkit.swift.

Yes, it will keep running even for 1 hour or 2 hours.

from haishinkit.swift.

Ok thanks for the feedback !

from haishinkit.swift.

But I'm not sure to undestrand "This is done to prevent audio and video desynchronization on the viewer's end when video is continuously dropped."
If the stream/connexion is closed, there is no desynchronization possible issue.

But it can lead to Fatal error: Attempted to read an unowned reference but object 0x280971800 was already deallocated when the encoder still running when not necessary. 🤔

from haishinkit.swift.

I see. I'm not a native English speaker, so I'm not quite sure about the main point. It would be helpful if you could explain it more concisely. I think you're talking about that stream.paused = false was set. Is that correct, or am I mistaken? https://shogo4405.github.io/HaishinKit.swift/Classes/RTMPStream.html#/s:10HaishinKit10RTMPStreamC6pausedSbvp

from haishinkit.swift.

I'm not a native English speaker so I'm probably not very clear also sorry.

I'm talking about when after stream.close(), the encoder is still running. To reproduce it:

• Take the example project
• Start the stream with an RTMP destination
• Stop (close) the stream
• Place a breakpoint in VideoCodec append()

The append() in the VideoCodec is still running even after a stream.close()

from haishinkit.swift.

It was an unintended behavior, so I have fixed it. Thank you.

from haishinkit.swift.

Thank you !

from haishinkit.swift.