Comments (6)
1.0.4 is a minor release and only contains bug fixes, should be a very straight forward upgrade but of course you should test before you launch. Worth a try to see if it fixes it, can't say for sure. I won't have time to look into this for a few weeks.
from articulate.
Thanks for the quick response. I tried upgrading, but that didn't resolve the issue. I'll just work around this issue with the old way of building macros for now.
from articulate.
The underlying problem is that for any virtual pages, the ID assigned to it is 'virtual', meaning that there is no corresponding real node in umbraco.
The error comes from this line in UmbracoHelper:
m.renderMacro(attributes, umbracoPage.Elements, this.UmbracoContext.PageId.Value);
As you can see it's using this.UmbracoContext.PageId.Value as the current page id. On a virtual page this will be based on a simple algorithm and int.Max value. So when the old macro object tries to look this up it gives an error since that id doesn't exist.
I think in order for this to work (even though i still think there might be issues), we'll have to modify the Umbraco core. Unfortunately the way macros render is based on code made a century ago so it's difficult to work with.
I'll log an issue on the umbraco tracker for this.
from articulate.
http://issues.umbraco.org/issue/U4-5943
from articulate.
Instead of using macros though, you can just use partial views directly... will be faster too. The only real reason to use macros nowadays is if you need support for your editors to insert macro parameters, which generally only pertains to the rich text editor or grid.
from articulate.
This is fixed in umbraco now in rev: umbraco/Umbraco-CMS@73e9ff0
from articulate.
Related Issues (20)
- Slug is lost during migration via BlogML
- Validation: The Alias field is required.
- Remaining work for 5.0.0 netcore release for Umbraco 9 HOT 22
- Question: Import WP blogs to Articulate HOT 2
- 404 On Tags / Category Page after moving content node from root to multisite node HOT 3
- Category & Tag Manipulation HOT 2
- To enable Sorting feature in the Blog Posts for Articulate
- BlogMl exporter doesn't handle code fences with language aliases
- It is not working on umbraco 11 HOT 1
- Articulate netcore site integration HOT 2
- Articulate 3.0.2 Pager.cshtml not fetching records when a child (ArticulateArchive) of root blog
- Disqus not rendering correctly in Material theme (maybe others)
- Articulate 5.0.1 causes all node URLs except the homepage to return 404 not found HOT 17
- Creation of dummy content HOT 1
- Articulate v5: GetAllCategories - not available anymore as UmbracoHelper extension?! HOT 3
- Articulate v5: Can filter articles by category or tag HOT 16
- ArticulateRootNodeCache InvalidOperationException: Sequence contains no matching element
- Umbraco.Core.Exceptions.BootFailedException: Boot failed. HOT 5
- RSS and Category Pages are giving 404 as in the site I used IContentLastChanceFinder HOT 4
- In current version date formated url (blog/2022/07/) giving 404 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from articulate.