Giter Club home page Giter Club logo

Comments (5)

SharpBit avatar SharpBit commented on May 29, 2024

Yes, the purpose of the MANIFEST.in file is supposed to include these when installing the package, however it seems like it is not installed locally

from brawlstats.

SharpBit avatar SharpBit commented on May 29, 2024

Workaround: Request the /characters endpoint to significantly reduce the size of the json file

from brawlstats.

smyaknti avatar smyaknti commented on May 29, 2024

Workaround: Request the /characters endpoint to significantly reduce the size of the json file

Why not only call for the JSON data when the BRAWLERS attribute is required just to speed it up. No need to call when initialising the client.
For the official API, I think its required only in the client.get_rankings() function. So for someone only tracking an individual's progress, it is not needed? Or I may have missed some important dependency of it.

from brawlstats.

SharpBit avatar SharpBit commented on May 29, 2024

Wow, this is an old issue. A problem that occured is that since this wrapper uses 1 client for both async and sync usage, we can't run the coroutine _aget_model inside of the sync function get_rankings. Any attempts for loop.run_until_complete do not work since the event loop is already running. See the development branch for the current implementation (fetched when client is initialized). Regular user usage works, you can test it on examples/async.py and it will work, but it fails in tox tests and will say that the event loop is already running,

from brawlstats.

SharpBit avatar SharpBit commented on May 29, 2024

Fixed in v4.0.4

from brawlstats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.