Giter Club home page Giter Club logo

Comments (2)

shariqfarooq123 avatar shariqfarooq123 commented on June 18, 2024 5

The paper uses Garg crop as defined here. All the crops are optional (technically) and you can easily enable or disable them during both training or testing by passing (or not passing) the respective arguments. See train.py and evaluate.py for the arguments explanation. Note that the Garg crop is commonly used as an evaluation mask and cuts off a significant portion (~40%, mostly in the sky-region) whereas kb_crop is more like an optional preprocessing step (e.g. Official dev-kit) for stripping off invalid regions (only about ~2-6%). You can refer to previous works such as this or this for usage.

For KITTI, official annotated depth data is used for both training and testing, found here: http://www.cvlibs.net/datasets/kitti/eval_depth.php?benchmark=depth_prediction

from adabins.

serizba avatar serizba commented on June 18, 2024

Hi @shariqfarooq123, Thanks for releasing the code of your work!

I've just ended with the same doubt as @xingyi-li. You pointed to previous work BTS where they do the kb_crop also for evaluating. I've just realized that BTS performs the crop on the input image, but then, when evaluating they use the full, uncropped ground truth. What they do is to fill the cropped predicted depth to match the ground truth depth.

On the other hand, on your code, when evaluating you perform first the kb_crop and then the garg_crop, what means that you are evaluating with a considerable smaller portion of the ground truth. Evaluating on the ground truth only with the garg_crop (and inputs with both crops as in BTS) worsens the results.

I am missing something? or is there any other work that performs both crops on the GT?,

thanks a lot!

from adabins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.