Yea, this could be related to us having redirections e.g. from sharetribe.fi to sharetribe.com. It might pick the sharetribe.dev too for that. This is something that clearly should be done better, thinking the open source version. We probably should separate some of our own logic from the master branch. Should figure our some best practices for that. I guess many open source projects face the same issue.

from sharetribe.

one quick fix here could be to make domain_redirect be enabled only if that's said in config.yml

from sharetribe.

or maybe?

if APP_CONFIG.domain == 'sharetribe.com'

from sharetribe.

yep, sounds good. :) I'll add that check now.

from sharetribe.

:) It seems I did pay some attention to other servers, as I wrote there:

# These rules are specific to the Sharetribe.com server, but shouldn't cause trouble for open source installations.

# # And you if you need your own rules for redirection or rewrite, add here.

and added "request.domain != APP_CONFIG.domain" requirement. So if you are using sharetribe.dev with your /etc/hosts/ you might want to set same domain in your config.yml.

We've been using lvh.me as that's already pointing to localhost. But I also added it to /etc/hosts to make it work offline too.

from sharetribe.

i had 'sharetribe.dev:3000' in config.yml while request.domain didn't have port so it run all those checks...
maybe we should change config.example.yml and also remove :3000 ?

from sharetribe.

I added the
APP_CONFIG.domain == 'sharetribe.com'
check so that should be enough to avoid redirects elsewhere for now

from sharetribe.