Comments (7)
@biste5 @patrick-rodgers I don't think we need a custom function. We can just use the built-in array.filter.
from pnp-js-core.
Agreed! We need to have as few dependencies as possible so the widest array of people can use it. Some companies have very specific restrictions on using "library x" or not.
from pnp-js-core.
I am looking into this, and seems the strongest dependencies on jQuery are on the provisioning part.
Unfortunately, this isn't covered by tests, and I don't know how to test it at the moment.
Fix to change after a quick look:
- remove jQuery.ajax calls: just one, it's basically done reusing HttpClient
- replace jQuery.grep with a custom utility function, which should be called grep or fiter (any preference?). Does it have to be IE8 compatible?
- remove remaining references of jQuery.Deferred
I have started, but not sure how far I can go in the next few days; also because first of all I think I'll try to write few tests to cover existing lacks in methods to adjust.
Let me know if I should issue a WIP PR or how to best handle this
from pnp-js-core.
Thanks for taking a look, that seems like a good list, I didn't think there was too much left. As for IE8 - no, don't worry about it. If someone needs IE8 support they can log a bug and we can revisit.
from pnp-js-core.
Thanks @mike-morrison and @patrick-rodgers !
from pnp-js-core.
I've covered I think 80% of the stuff, it's pushed atm to
https://github.com/biste5/PnP-JS-Core/tree/dev_74
What remains it's all in objectfiles.ts
- jQuery.get to get raw content of a file (line 25), and definition of a web part (Line 100) (?)
- jQuery.when.apply at Line 31, looks a bit fragile to me, and I didn't know yet how to convert it to Promise safely
- jQuery.extend, mainly at Line 179. (That one at line 27 can be easily rewritten using vanilla JS)
from pnp-js-core.
Closing this, nice work Massimo.
from pnp-js-core.
Related Issues (20)
- return type for getAll HOT 2
- Handling HTTP 400 Errors via catch HOT 2
- Qustion: The field 'xxxx' is not supported in query. The lookup list is in another web. HOT 1
- [Question]: Retrieve all files within a document library HOT 2
- multiple delete does not work with String Array! HOT 3
- Sharing Site collection to an external user HOT 1
- Uploading package to app catalog HOT 4
- Is it possible to fetch data from client side modern page and show it into a new page SPFX HOT 2
- A call to contextInfo is being made by each spfx webpart. HOT 1
- When I try to upload large file on SharePoint 2013 On-Premise it gives error Resource not found HOT 1
- UserProfile MyProperties with error 500 HOT 2
- Cannot get FileRef from getItemsByCAMLQuery method HOT 1
- how to add field to view? HOT 2
- Trying to update sharepoint library metadata column using pnp js HOT 1
- IncludeGroupsSites doesnt work in the sp.social.my.followed(SocialActorTypes.IncludeGroupsSites) HOT 1
- Using Angular@6 util.js error HOT 3
- Having issues adding User and Lookup fields to List HOT 2
- How to get specific version of item? HOT 3
- Ability to view/add/remove Site Collection Admins? HOT 2
- SPFX and AD Groups Permissions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pnp-js-core.