Giter Club home page Giter Club logo

Comments (1)

ShaneGH avatar ShaneGH commented on June 9, 2024

A possible fix is as follows. Steps should be done in a different order than below so as to do in small incremental changes

  • change method signature of export function params<TRoot>(uriRoot: string, serviceConfig: ODataServiceConfig, schema: ODataSchema): [ParameterDefinition[], Params<TRoot>] to return Params<TRoot> (no more mutable array)
  • change Params<TRoot>, make it contain a ParameterDefinition
  • change QbEmit. Give it a second parameter that maps @param names to ÒDataTypeRef
  • Rename QbEmit to something that represents the entire query. This class will be used a lot
  • Change EVERYTHING to return a Writer<T, QbEmit>
    • Start with serialize method. Serialize has both a T (which might be a Params<Root>) and an ODataTypeRef. It can emit (Writer monad) a QbEmit with a mapping from a param to it's type
    • From there it is a a cascade which will include changing EVERYTHING to a Writer (or maybe State) monad

Once all mutable state is gone, it will be safe to add any changes needed to fix this bug

from magic-odata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.