Giter Club home page Giter Club logo

Comments (3)

knzconnor avatar knzconnor commented on September 2, 2024

Oh, I was probably going to also move test-site into a branch (and add an option for build from branch).

Maybe get funky and make sub-actions via subtree and branches. could have the build and check things be stand-alone in case people wanted to use them via action-name@syntax but still live in the main repo to not need an extra submodudule checkout

from zola-deploy-action.

shalzz avatar shalzz commented on September 2, 2024

Can you please describe the changes you are proposing to make, in addition to having history on the deployment branch?

From a quick look it looks like a major change in the way variables are defined and provided to the action, so it would be better to have it as a separate/new action so that we don't break the workflow of people already using this action.

from zola-deploy-action.

knzai avatar knzai commented on September 2, 2024

To start, not erasing peoples repositories (based on some comment I saw in Discourse) if they get it wrong. No unwarned force pushes in an action!? Or overall forcing history erasure (that was why I started my refactor). And in the process isolating the action to be just the zola pieces for easier maintenance (and leaving github token issues to the checkout or deploy step to simplify the code and usage). And using a composite action for composability etc (see zola-cli@check).

It seems like most of the open issues go away if you don't do the git push step manually yourself: cross host auth tokens, history, etc are simpler just relying on a checkout action and pushing to that, much less using an action to even manage that. Originally I just did the checkout then mv .git to the content folder shuffle, but it was even simpler when I stopped managing that piece manually myself.

In the end I just ended up refactoring my own to use James Ivey's more generic and broadly used "deploy to gh-pages" for that step and focused on the zola. :)

Since you have the repo that is referenced in documents, and I started with that I'm happy to push any changes upstream of course. But as it's a much different approach at this point, so if you decide it's not a direction you like, I gave you a shoutout in the acknowledgements (even if I'm not sure there's an original line left).

Cheers

https://github.com/knzai/zola-build
https://github.com/knzai/zola-cli

from zola-deploy-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.