Giter Club home page Giter Club logo

Comments (7)

wongsyrone avatar wongsyrone commented on June 26, 2024 4

333412b786c353dc5a761aa7ed3bf75b_b
吼啊

from shadowsocks-org.

madeye avatar madeye commented on June 26, 2024 1

a) 16 bytes overhead means 16 / 1492 (typical chunk size if MSS = 1492) ~= 1% bandwidth loss. I doubt the overhead is even notable in the real world.
b) The approach of OpenSSH doesn't look good to me, especially the two separate ciphers.
c) Since SIP004 is already finalized, I prefer to not changing AEAD ciphers, unless there is any security concern.

I suggest to do more research for any new AEAD cipher that would solve the chunk length issue internally.

from shadowsocks-org.

shinku721 avatar shinku721 commented on June 26, 2024

I have seen similar construction in obfs4, although obfs4 uses a strange (maybe invented by itself) stream cipher.
Maybe we can drop the length tag, ignoring the authenticate error of the length field, and include the length as Associated Data in payload part. However I'm not sure whether the encryption library allows us to do this.

from shadowsocks-org.

shinku721 avatar shinku721 commented on June 26, 2024

And as the protocol is frequently modified I think we must mark the stability on website.

from shadowsocks-org.

riobard avatar riobard commented on June 26, 2024

Maybe we can drop the length tag, ignoring the authenticate error of the length field, and include the length as Associated Data in payload part. However I'm not sure whether the encryption library allows us to do this.

It won't work. By definition AEAD ciphers will refuse to decrypt if authentication fails so as to avoid providing a decryption oracle to attackers.

from shadowsocks-org.

riobard avatar riobard commented on June 26, 2024

I think the question is a) whether 16 bytes overhead per chunk is acceptable and if not b) should we adopt similar design like the one used in OpenSSH.

from shadowsocks-org.

riobard avatar riobard commented on June 26, 2024

I agree. The OpenSSH design leaves the possibility open that adversaries can control the obfuscated length field. Even though it does not pose any security threat because the payload is still AEAD-protected, I wonder if it exposes timing characteristics that might enable attacks similar to @breakwa11's to identify the protocol we use.

from shadowsocks-org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.