Giter Club home page Giter Club logo

Comments (14)

dmitry avatar dmitry commented on July 21, 2024

Please add support.

from capistrano-db-tasks.

sauliusgrigaitis avatar sauliusgrigaitis commented on July 21, 2024

Check my fork sauliusgrigaitis/capistrano-db-tasks@1c5f0ef for Capistrano 3 support.

from capistrano-db-tasks.

dmitry avatar dmitry commented on July 21, 2024

Can you do a pull-request?

from capistrano-db-tasks.

sauliusgrigaitis avatar sauliusgrigaitis commented on July 21, 2024

It's not backward compatible with Capistrano 2, merging back would make legacy users unhappy.

from capistrano-db-tasks.

dmitry avatar dmitry commented on July 21, 2024

What about moving those changed into a new branch with a new major version? Or you can change s.add_development_dependency "capistrano", "> 2.0.0" to s.add_development_dependency "capistrano", "~> 3.0"?

from capistrano-db-tasks.

sauliusgrigaitis avatar sauliusgrigaitis commented on July 21, 2024

I believe best way would be to support both v2 and v3. Frankly, original code is very coupled, I don't see easy and nice way how to make support for v2 and v3. Maybe somebody has an ideas and time to make it.

from capistrano-db-tasks.

sgruhier avatar sgruhier commented on July 21, 2024

I think may be the best is to make a cap2.0 branch and to release this version (0.3?)
Then merge @sauliusgrigaitis Capistrano 3 support to master (and may be release it as 0.4)
Any other ideas?

from capistrano-db-tasks.

sgruhier avatar sgruhier commented on July 21, 2024

legacy users should use rubygems.org and not github/master

from capistrano-db-tasks.

dmitry avatar dmitry commented on July 21, 2024

I agree with @sgruhier. Legacy users will use rubygems. If they will do bundle update, then the add_dependency with the new version will prevent gem from updates. Code for capistrano 3.0 should be in master branch, and legacy code in branch something like v0.3.

from capistrano-db-tasks.

sauliusgrigaitis avatar sauliusgrigaitis commented on July 21, 2024

Sounds like a plan. I can make pull request if no one has more ideas.

from capistrano-db-tasks.

sgruhier avatar sgruhier commented on July 21, 2024

you already made a PR no?
It's late now for me (in France), I have to go.
I'll look at it tomorrow and do it. In the mean time, you have any idea, new PR or anything that can help, I'll really appreciate.
Thanks for the cap v3 support!!

from capistrano-db-tasks.

dmitry avatar dmitry commented on July 21, 2024

Thanks for the support.

from capistrano-db-tasks.

sauliusgrigaitis avatar sauliusgrigaitis commented on July 21, 2024

It's my pleasure to contribute!

from capistrano-db-tasks.

sgruhier avatar sgruhier commented on July 21, 2024

Big thanks to @sauliusgrigaitis

from capistrano-db-tasks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.