Giter Club home page Giter Club logo

Comments (9)

william-silversmith avatar william-silversmith commented on May 25, 2024

Yup, that looks like a bug to me. Let me check it out.

from connected-components-3d.

william-silversmith avatar william-silversmith commented on May 25, 2024

I've just uploaded a new version to PyPI! Please give it a test and let me know if that solves it for you.

from connected-components-3d.

tengssh avatar tengssh commented on May 25, 2024

Yes, it solves the problem and the results now make more sense to me.
Btw, would it be possible to implement a periodic boundary condition? I understand that experimental images may not consider it, but having this option for simulations would be cool.
Thank you again for solving this issue!

from connected-components-3d.

william-silversmith avatar william-silversmith commented on May 25, 2024

from connected-components-3d.

tengssh avatar tengssh commented on May 25, 2024

Hi,

It means that D(x)=D(x+L), where L is the length of the box along x, so that in the following case:

data = np.array([[3,3,0,3,3]])
labels_out = cc3d.connected_components(data, connectivity=6)

Thereby instead of array([[1,1,0,2,2]], dtype=unit16) it will output array([[1,1,0,1,1]], dtype=unit16) if periodic boundary condition is applied.
Maybe this wiki would be helpful in explaining what I meant.

from connected-components-3d.

william-silversmith avatar william-silversmith commented on May 25, 2024

Oh I see what you mean. That's an interesting application. I'll consider it.

from connected-components-3d.

william-silversmith avatar william-silversmith commented on May 25, 2024

Would you need support for 6 connected only? It's a lot more tractable to support it for a limited number of connectives. I believe there are 8 separate CCL implementations in the codebase: 4, 8, 6, 18, 26, and three continuous domain versions. I don't think I'd have time to do more than a few of them.

from connected-components-3d.

william-silversmith avatar william-silversmith commented on May 25, 2024

Might be good to continue this conversation here: #117

from connected-components-3d.

tengssh avatar tengssh commented on May 25, 2024

Would you need support for 6 connected only? It's a lot more tractable to support it for a limited number of connectives. I believe there are 8 separate CCL implementations in the codebase: 4, 8, 6, 18, 26, and three continuous domain versions. I don't think I'd have time to do more than a few of them.

Thank you! I think 6 should be enough.

from connected-components-3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.