python3.9 compatibility about fastnumbers HOT 5 CLOSED

Thanks for reporting.

from fastnumbers.

It appears _Py_dg_stdnan is no longer present (actually, dtoa.h is gone entirely).

The following program can reproduce this easily:

#include <Python.h>

int main()
{
  printf("%f\n", _Py_dg_stdnan(0));
  return 0;
}

It outputs nan in Python 3.8 and 0.000000 with 3.9 (with a GCC warning: implicit declaration of function '_Py_dg_stdnan' [-Wimplicit-function-declaration].

An easy workaround is to include internal/pycore_dtoa.h instead:

#define Py_BUILD_CORE 1
#include <internal/pycore_dtoa.h>
#undef Py_BUILD_CORE

This passes all tests here with Python 3.9.

from fastnumbers.

@felixonmars Thanks for the debug of how to find the new dtoa.h. Though, I probably should stop depending on internal, non-public functionality, so I'll try to make a more robust fix.

from fastnumbers.

FYI - this was fixed as part of fastnumbers 3.1.0

from fastnumbers.

Thanks! I've updated to 3.1.0 in the repos as well :)

from fastnumbers.