Giter Club home page Giter Club logo

Comments (4)

jdm avatar jdm commented on June 13, 2024 1

This seems reasonable to me! I'm not sure why we didn't integrate the concrete types originally.

from servo.

gterzian avatar gterzian commented on June 13, 2024

@jdm Does this make sense? Do you know why this wasn't done to begin with?

from servo.

gterzian avatar gterzian commented on June 13, 2024

Had a quick look everywhere, it seems there are really four cases:

  1. Should return some variant of js::typedarray (the majority). Dealt with in this issue
  2. Should return a ReadableStream, see #30891
  3. Should return an enum, see #30890
  4. Should return a WebGL extension, which is actually an object? in WebIDL. See #30892

from servo.

gterzian avatar gterzian commented on June 13, 2024

See also https://github.com/servo/mozjs/blob/de842d84a07eabac4e1bfe72a954b74ee0244b82/mozjs/src/conversions.rs#L722

It may be that what is required is simply implementing ToJSValConvertible for the various types in js::rust::typedarray

In some ways it would in that case still be nicer to wrap the use of js:: inside dom/bindings...

from servo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.