Merging a dynamic into the view model about servicecomposer.aspnetcore HOT 7 CLOSED

Great catch @MarcusChamberlain. I'll get it fixed. If I end up using the same approach as for RaiseEvent I can also drop the IDynamicViewModel interface entirely.

from servicecomposer.aspnetcore.

Hi @MarcusChamberlain, thanks for raising this. Never thought about that scenario, indeed sounds interesting and doable. I see to options:

• DynamicViewModel has a Merge method
• DynamicViewModel implements IDictionary<>

Thoughts?

from servicecomposer.aspnetcore.

Thanks for taking a look into this. Being able to call 'vm.Merge(myDynamic)' on the view model would be very nice.

from servicecomposer.aspnetcore.

@MarcusChamberlain I raised #33 to address this. The only thing I'm not sure about is the Merge behavior, right now I took the simplest approach that is to overwrite existing properties in DynamicViewModel. Obviously this can lead to some strange scenarios like:

dynamic d = new DynamicViewModel(....);
d.SomeProperty = 10;

dynamic source = new ExpandoObject();
source.SomeProperty = "some value";

d.Merge(source);

It'll work but now the DynamicViewModel instance SomeProperty type changed from int to string.

I could check that in case of overwrite the type is the same.

Thoughts?

from servicecomposer.aspnetcore.

Hi Mauro

The merge solution looks great. I did notice one issue though.

At the moment your unit tests (in the 'When_merging_to_DynamicViewModel' class) are able to run because you have a compiler instruction to make internal classes visible to the external assembly 'ServiceComposer.AspNetCore.Tests'. This is tricking your tests into passing - if you attempt to use vm.Merge() in an project without that compiler instruction, you'll get an error that DynamicViewModel does not contain a method called Merge().

This occurs because the call to Merge() goes through the 'TryInvokeMember' method. This has been set to only allow calls to 'RaiseEvents'.

The fix is to add the following to 'TryInvokeMember':

            if (binder.Name == "Merge")
            {
                this.Merge(args[0] as IDictionary<string, object>);
                return true;
            }

from servicecomposer.aspnetcore.

@MarcusChamberlain I just pushed a fix to #33

from servicecomposer.aspnetcore.

Merged the PR and deployed 0.0.11 to Nuget. Thanks @MarcusChamberlain.

from servicecomposer.aspnetcore.