Giter Club home page Giter Club logo

Comments (5)

amithm7 avatar amithm7 commented on May 14, 2024 1

@ignoramous yes, blocking works on deno now, but node/ fly is broken with that commit: https://github.com/serverless-dns/serverless-dns/runs/4924780290?check_suite_focus=true

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024 1

Fixed: 15f5df6 Thanks. :D

from serverless-dns.

amithm7 avatar amithm7 commented on May 14, 2024

Something here is losing the config / url?

serverless-dns/src/server-deno.ts

Lines 106 to 110 in 33500e9

// doc.deno.land/deno/stable/~/Deno.RequestEvent
// deno.land/manual/runtime/http_server_apis#http-requests-and-responses
const req = requestEvent.request as Request;
const rw = requestEvent.respondWith.bind(requestEvent) as Function;
res = handleRequest(mkFetchEvent(req, rw));

This is the only change I see...

Also, type assertion (as Type) isn't required on line 108 & 109 as there is no ambiguity.

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

The "blocklist" Map was always adjudged "empty" on Deno (and hence blocking didn't work), because of this line of code:

serverless-dns/src/commons/util.js

Line 315 in 1b60d56

if (!m.__proto__.hasOwnProperty("size")) return true;

Seems like __proto__ isn't Deno's cup of tea...

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

Blocks should be up and running on Deno now: 881d891

from serverless-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.