Giter Club home page Giter Club logo

Comments (10)

ignoramous avatar ignoramous commented on May 14, 2024

Yikes. Is Deno Deploy completely down due to this error?

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

This may be the fix: 995f4dc

Can you please test? (I should get my act straight and treat Deno deploys more seriously).

Btw, an rxid aka rx.47n5vyse9a.sz3pl3y4nd you see in the logs, should give you all logs the process emitted for any one given DNS request.

from serverless-dns.

 avatar commented on May 14, 2024
0 doh proxy-request error TypeError: Cannot read properties of undefined (reading 'bind') at new RethinkPlugin (file:///src/index.bundle.js:7551:62) at proxyRequest (file:///src/index.bundle.js:7729:24) at handleRequest (file:///src/index.bundle.js:7723:12) at serveHttp (file:///src/index.bundle.js:7813:19)

Here is the updated logs after 7c04a5d update for your references. I skip to the latest logs without hostname address(my ip).
The results:
Unable to connect it. e.g:(https://xxxx.deno.dev/)

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

Strangely, local Deno setup works just fine... Is it deno bundle that's stricter here...?

Another attempt to get Deno deploy to work: 8a70540

from serverless-dns.

 avatar commented on May 14, 2024
0 2022-01-23T16:09:57.748Z W Deno serv fail doh request Error: missing request at mkFetchEvent (file:///src/index.bundle.js:7890:28) at serveHttp (file:///src/index.bundle.js:7816:33)
1 2022-01-23T16:09:57.747Z W Deno serv fail doh request Error: missing request at mkFetchEvent (file:///src/index.bundle.js:7890:28) at serveHttp (file:///src/index.bundle.js:7816:33)
2 2022-01-23T16:09:57.040Z W Deno serv fail doh request Error: missing request at mkFetchEvent (file:///src/index.bundle.js:7890:28) at serveHttp (file:///src/index.bundle.js:7816:33)
3 2022-01-23T16:09:57.033Z I Deno DoH listening on: [127.0.0.1]:80
4 not workers, no-op http-cache-api
5 svc: systemReady
6 Console level set: info

Heres the latest log for the update at build/deno-deploy/dev.

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

cc: @amithm7

I am out of ideas on why Deno works locally but not on Deno Deploy. I believe the current error might have something to do with function overloading / type mismatch between how mkFetchEvent is defined (mkFetchEvent(Request, Function[])) versus how it is called (mkFetchEvent(Request, Function))?

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

I think I may have unwittingly fixed the error: e3deac7 ;)

from serverless-dns.

amithm7 avatar amithm7 commented on May 14, 2024

@ignoramous

We have our own logs here: https://dash.deno.com/projects/rdns

Issue is that env.runTime mapping has a default value.

Logs from deno-deploy (read bottom-up):

[Debug]	Added runTime node
[Warn]	runTime env[key] default value: node
[Info]	Loading env. from runtime: deno
[Warn]	Deno.env.set() is not available =>  TypeError : Can not modify env vars during execution.
[Warn]	.env file may not be loaded =>  TypeError : Deno.readFileSync is not a function
[Debug]	isolate start time: 996 milliseconds

const _ENV_VAR_MAPPINGS = {
runTime: {
name: "RUNTIME",
type: "string",
default: "node",

This is not affecting locally, as Deno.env.set() works, but not on deno-deploy.

try {
// override: if we are running this file, then we're on Deno
Deno.env.set("RUNTIME", "deno");
} catch (e) {
// Warning: `set()` method is not available in Deno deploy.
console.warn("Deno.env.set() is not available => ", e.name, ":", e.message);
}

IMO, runtime, cloud platform, etc. shouldn't have defaults.

env.runTime is prgrammatically handled:

// On deno deploy, env variables can not be modified during execution,
// so, Deno.env.get("RUNTIME") may return null, if programmatically set.
if (this.runtime === "deno" && !renv.runTime) {
renv.runTime = "deno";
}


Also, I saw that alpn was added to deno DoH, but Deno's unstable API is not supported on deno-deploy. Edit: Nevermind, there is no TLS termination in-app on deno deploy.

from serverless-dns.

amithm7 avatar amithm7 commented on May 14, 2024

fixed.

Or not: #51

from serverless-dns.

ignoramous avatar ignoramous commented on May 14, 2024

Deno must now be up and running...

Locally Deno (./run deno) does work, and I observed our test setup on Deno Deploy does too.

A lot of improvements needed still... So as and when those happen, expect more hiccups ;)

from serverless-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.