Postal Code for CA/UK returns regex, not an actual Postal Code about kotlin-faker HOT 5 CLOSED

PR #193 opened. This should cover all locales that don't use "#" based postal codes. Tests and Integration tests pass. Added a new test for en-CA postal codes.

from kotlin-faker.

Hi @efenderbosch-atg ,
Thanks for opening this issue!

Yes, you're likely right that en-GB locale needs to be handled separately, like the nl one. I really haven't gone through all of the localizations to find these kinds of issues, and only fix them when I or someone else encounters it :)
Would you like to submit a PR with a fix?

from kotlin-faker.

I can probably do that. I'm wondering if the when is required at all? Would this simply cover all use cases?

fun postcode() = with(fakerService) { resolve("postcode").generexify().replace("/", "") }

from kotlin-faker.

I can probably do that. I'm wondering if the when is required at all? Would this simply cover all use cases?

fun postcode() = with(fakerService) { resolve("postcode").generexify().replace("/", "") }

Up to you , but if you want to contribute - you're welcome to do so :)

No, it won't. Most postcodes aren't in the form of regex, but use # chars as a placeholder for a digit (e.g.

from kotlin-faker.

This should be available in latest snapshot after the build finishes.
Otherwise I'll make a new RC version later this week.
Thanks for your contribution

from kotlin-faker.