(safe)Email sometimes creates invalid email addresses (for certain locales?) about kotlin-faker HOT 4 CLOSED

Yeah, the RFC is super weird indeed. Thanks for the explanation though! I think the issue lies more at Valiktor's side then here, you have a good point there.
I'll close it with that reason.

from kotlin-faker.

No problem. Hope faker is still useful for you in it's current form :) And feel free to open another issue if you find something not working as expected or need help with something.

from kotlin-faker.

Also tried it with locale en-EN which gives emails like kieth.o'[email protected] and danelle.o'[email protected].

from kotlin-faker.

Hi @martinvisser , thanks for raising the issue.
If I understand correctly, the issue for you is either ' (or potentially other special chars) and/or accented letters? I'm not sure what rules the library you mention uses to validate emails, but IIRC what is allowed in the RFC-2822 for the local part (before the @some.domain) of the email address, then all of the email addresses you've posted here are valid.
Then again, email validation should be a very domain-specific thing, and from my experience, I don't think you generally want to conform to the RFC standards for email addresses, because frankly they allow very weird stuff.
Having your application targeted to users who live in Netherlands, for example, you might want to allow people to use accented characters in their names, such as jurriën, or you might not want to do that. That's up to you as an app developer, but RFC allows these chars, for example.

Now to what's actually causing this. The problem here is that an email is generated from a person's name (if you don't hardcode the name yourself of course):

So if you don't want special chars like ' or accented letters like ë in your accepted email addresses, my suggestion would be to create a wrapper function that would replace them after the email has been generated, e.g.

fun normalizedEmail(): String {
    return faker.internet.email().replace("ë", "e")
}

A very crude example which can easily be expanded to cover all your specific cases.

from kotlin-faker.