Comments (9)
can you explain a little bit more maybe put an example
from node-decorators.
Hi @markkelsall. At the moment simple functions are not supported. All the middlewares have to be classes. In order to use plain function you would need to wrap it. Is it inconvenient to use middleware as classes?
from node-decorators.
Hi @serhiisol ok got it.
Yes ideally it would be better to be able to use simple functions (async included) as middleware as well as classes.
I was under the impression that the code supported it and it was just the typings that I was getting wrong, based on this - https://github.com/serhiisol/node-decorators/blob/master/express/src/middleware.ts
from node-decorators.
I’m going to add support of the simple functions
from node-decorators.
That would be great, will make adoption for new devs a lot easier!
Do let me know when you have a change ready to look at
from node-decorators.
Hi, @serhiisol, is the only change for this issue/feature request the one commit then? I saw there are a few things going in as part of this linked PR and results in a new major version
from node-decorators.
Most of the changes are required and probably it might break something.That's why I called it major changes. For example, if you're returning something you would need to be able to setup status code. Then there were few bugs that I fixed. Technically I can only revert the update of express.
from node-decorators.
Ok, I’ll try to split the changes into a bunch of PRs
from node-decorators.
Ok great, let me know how you’re getting on and whether it’s just that simple change you had previously
from node-decorators.
Related Issues (20)
- Feature Request - Plugin Server System HOT 6
- Injection failed for classes with properties in constructor HOT 1
- After Using Next response from other controllers are empty HOT 2
- Cannot read properties of undefined (reading 'use') HOT 1
- Question: example of how to use error middleware? HOT 10
- Feature Request - Dynamic controller (class) instance HOT 9
- Container.get returns a Promise HOT 2
- Feature Request - attach custom decorators HOT 5
- Feature request - Custom http code handling HOT 3
- Typescript v5 injection of type undefined HOT 11
- socket decorator not working HOT 1
- TypeError: Cannot read properties of undefined HOT 4
- Decorators with inheritance HOT 4
- Error while inject property in middelwares HOT 6
- Error injection HOT 18
- Where is attachMiddleware o how it change? HOT 2
- Where did the flexibility go?! HOT 11
- @Controller & Rest methods no longer work HOT 1
- Can't attach a controller without an error middleware HOT 17
- HttpModule is not exported HOT 21
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-decorators.