Comments (4)
Also sorry for randomly dropping a bunch of issues on you on Christmas.
from rocket.
No worries on the issues! I appreciate your diligence. :)
I've given some thought to this, and at present, I'd rather keep derives as they are. My main argument against moving to macros 1.1 is that it adds another crate, and thus another line to src/main.rs
. I expanded on this in the following comment: rust-lang/rust#37128 (comment).
That being said, it may be possible to reexport the derives from the core rocket
crate, and so you'd only need to add #[macro_use]
to extern crate rocket
. If the derive code for macros 1.1 is significantly cleaner, for whatever reason, and this reexport can indeed be done, then I might be convinced. Still, I worry that this avenue might be confusing to users. Why should they import a plugin via #[plugin(...)]
and do a #[macro_use]
? Codegen can be a confusing subject, and I'd like to avoid all means to further confusion.
from rocket.
It would need to be a separate crate as it's a separate compilation mode.
from rocket.
I'm okay with having another crate as long as users don't need to explicitly import it. What I was referring to was that it might be possible to, in the rocket
crate, add something like:
#[macro_reexport] extern crate rocket_derive;
And then users would write:
#[macro_use] extern crate rocket;
Is this what you're referring to when you say it won't work? I haven't explored this myself.
from rocket.
Related Issues (20)
- Clippy lint: temporary with significant `Drop` can be early dropped HOT 1
- Rocket sometimes resets connection instead of responding with 413 error response HOT 2
- MiniJinja can't be used for templates HOT 1
- Routing by hostname HOT 10
- New release of rocket_dyn_templates HOT 3
- Redirector issue in TLS example HOT 5
- Deployment Docs - Static Files HOT 1
- FromForm Option<Result> with custom type HOT 4
- Possible error in the Json guard HOT 3
- Allow Generics in route functions HOT 1
- Caching a background image with the `Cache-Control` header HOT 2
- sslmode=required not working for rocket_db_pool with feature diesel_postgres HOT 1
- Fairing returns incorrect Content-Length for status 204 HOT 7
- No way to turn off coloured log output HOT 2
- Implement derive FromParam for enum HOT 1
- Websockets (and any other connection upgrade) does not support local testing.
- `rocket_http` doesn't bulid/test on `rust` `1.80.0` HOT 1
- Expose the `tracing` layer construction to allow you to add other e.g. tracing_subscribers HOT 2
- Implement `PartialEq` for `http::Status` with derive macro HOT 4
- SQLx, Diesel, etc RUSTSEC tracking issue. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocket.