Giter Club home page Giter Club logo

Comments (5)

bwendling avatar bwendling commented on September 26, 2024

Note: You may need to increase the number of goroutines to 1000 or so.

from go-diff.

zimmski avatar zimmski commented on September 26, 2024

Needed 10000 goroutines to get a missmatch (and needed to changed the expected data, are you running the latest version?) 👍 However, this should be expected under load because of the timeout argument that is set to one second by default. Please add the following to your example. If you are still getting mixed results we should have serious look at this.

func init() {
	dmp.DiffTimeout = 0    // Do not time out on diff matching
}

Maybe we should change the default timeout so that there is no timeout?

from go-diff.

bwendling avatar bwendling commented on September 26, 2024

Ah! A timeout might explain things. I updated to the latest version after filing this, but I still had the same issue (as you discovered, you have to set it to over 10000). Anyway, I'll try the timeout setting. Thanks!

from go-diff.

zimmski avatar zimmski commented on September 26, 2024

Please let me know how it went

from go-diff.

bwendling avatar bwendling commented on September 26, 2024

It didn't go well. Setting dmp.DiffTimeout to 0 made it run indefinitely. I'm not so sure it matters though, because it takes so many goroutines to have it show.

from go-diff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.