Giter Club home page Giter Club logo

Comments (7)

sergeykomlach avatar sergeykomlach commented on June 20, 2024 1

It doesn't have any effect on the final code execution, just warns about unexpected cases.?

Yup, the library works as expected so far, though I don't have all the devices you have to test vendor edge cases.

It seems like I need to do some fine-tuning in Proguard rules.

Thanks!

You already can try the new version 2.2.4 for me the issue with Missing class... is gone.
Remains R8 warnings, that's relate class file version - some old JAR libraries from Samsung/Meizu contains classes, compiled with ClassVersion=50, when now ClassVersion=51 required.
I'm working under this fix too

from advancedbiometricpromptcompat.

sergeykomlach avatar sergeykomlach commented on June 20, 2024

Hi.
Such a log appears because the library uses some device-specific and/or Gray-listed classes, so R8 during obfuscation can't create a references tree properly.
It doesn't have any effect on the final code execution, just warns about unexpected cases.?
It seems like I need to do some fine-tuning in Proguard rules. Thank you for reporting

from advancedbiometricpromptcompat.

RobbWatershed avatar RobbWatershed commented on June 20, 2024

It doesn't have any effect on the final code execution, just warns about unexpected cases.?

Yup, the library works as expected so far, though I don't have all the devices you have to test vendor edge cases.

It seems like I need to do some fine-tuning in Proguard rules.

Thanks!

from advancedbiometricpromptcompat.

RobbWatershed avatar RobbWatershed commented on June 20, 2024

Unfortunately, I can't test it right now as you've included window:1.2.0-beta01, which needs API34. However, my app hasn't made the jump yet 😅

from advancedbiometricpromptcompat.

sergeykomlach avatar sergeykomlach commented on June 20, 2024

@RobbWatershed so I downgrade the window version, now should be OK.
Also added a new section to README
Most of the warnings were removed, remains only a few, related to Samsung's libraries and older Class File versions (50 instead of modern 51).
Honestly, do not see any way how to remove it

from advancedbiometricpromptcompat.

RobbWatershed avatar RobbWatershed commented on June 20, 2024

Thanks! I confirm missing classes are not among warnings anymore 👌

However, I'm still getting ~40 lines of

AGPBI: {"kind":"warning","text":"Expected stack map table for method with non-linear control flow. In later version of R8, the method may be assumed not reachable.","sources":[{"file":"C:\\Users\\aaa\\.gradle\\caches\\transforms-3\\5c959d4a266b6bc524525b8e67075321\\transformed\\biometric-2.2.5-runtime.jar"}],"tool":"R8"}

As it says "In later version of R8, the method may be assumed not reachable", shouldn't I completely exclude your library to the scope of R8 to avoid future issues?

from advancedbiometricpromptcompat.

sergeykomlach avatar sergeykomlach commented on June 20, 2024

As I said earlier, some warnings from Samsung Pass SDK remain - I didn't find a way to suppress or hide these warnings
They don't have an effect on libraries or applications for now, but I'll continue watching, maybe in future just update the minimal SDK level in the library and remove obsolete SDKs like Samsung Pass or Meizu SDK

from advancedbiometricpromptcompat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.