change of type crashes my electron app about rollup-plugin-node-externals HOT 7 CLOSED

I just run into the same issue.

find-up version 6 is ESM only, so const findUp = require('find-up'); (from your dist/cjs/index.js) throws an error:

Error [ERR_REQUIRE_ESM]: Must use import to load ES Modul

Edit: I'm working on an ordinary node setup (no electron)

from rollup-plugin-node-externals.

Oh dear. TBH, I'm beginning to get really, really, really tired of those commonjs/esm issues 😢

@lmestel > could you please try with 3.0.0 and tell me if it works? find-up was mistakenly bundled in 3.0.0, which is why I released 3.0.1 in the first place. But in the end, it might just be the right way to go.

@hmt > is your issue the same as @lmestel's or completely different?

from rollup-plugin-node-externals.

no, it's different. Doesn't say exactly what's wrong, doesn't even mention this plugin by name.

from rollup-plugin-node-externals.

I'm beginning to get really, really, really tired of those commonjs/esm issues

I feel you!

could you please try with 3.0.0

Oh, I didn't mention, that the error ocoured with version 3.1.0.
With 3.0.0 the build workes! 👍
But I had to change const externals = require('rollup-plugin-node-externals'); into const { default: externals } = require('rollup-plugin-node-externals'); (otherwise I get TypeError: externals is not a function 🤷)

from rollup-plugin-node-externals.

This is hopefully fixed in 3.1.1. Please let me know.

from rollup-plugin-node-externals.

Thank you! It works again. I don't even know why I need your plugin but it somehow solves a bunch of issues I have when trying to build my app without :S

from rollup-plugin-node-externals.

👍 Thank you very much!

from rollup-plugin-node-externals.